Fix dot handling in dist-info directory name #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
search-dot-in-dist-info
branch
from
bb271cb
to
49cc36f
Compare
When searching for a matching dist-info directory, try to escape dots in the name segment. This makes functions like distribution() able to accept PEP 503 normalized names to locate a distribution's dist-info directory if the distribution's name contains dots.
uranusjr
force-pushed
the
search-dot-in-dist-info
branch
from
49cc36f
to
8fb96b0
Compare
jaraco
reviewed
Nov 22, 2020
jaraco
reviewed
Nov 22, 2020
jaraco
reviewed
Nov 22, 2020
jaraco
force-pushed
the
search-dot-in-dist-info
branch
from
0d263db
to
d027af6
Compare
|
In the subsequent commits, I've added tests to capture both the desired normalization behavior, but also capture support for the dot-based metadata as "legacy". |
uranusjr
commented
Nov 22, 2020
|
I've targeted this PR at the maint/2.x branch so it can be rolled out for users on Python 3.5 and 2.7. |
|
Please let me know what you think of this implementation. If you're happy enough with it, I'll merge and push it out as 2.1 and 3.1. |
|
Everything looks to me now 👍 |
|
FYI, this change has caused a regression in discovery of versionless distributions still using the dot (#261). |
jaraco
added a commit
that referenced
this pull request
Dec 21, 2023
jaraco
added a commit
that referenced
this pull request
Dec 21, 2023
jaraco
added a commit
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching for a matching dist-info directory, try to escape dots in the name segment. This makes functions like
distribution()able to accept PEP 503 normalized names to locate a distribution’s dist-info directoryif the distribution’s name contains dots.
Related discussions: