Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test --enable-pystats in CI #99873

Open
mdboom opened this issue Nov 29, 2022 · 1 comment
Open

Test --enable-pystats in CI #99873

mdboom opened this issue Nov 29, 2022 · 1 comment
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@mdboom
Copy link
Contributor

mdboom commented Nov 29, 2022

Feature or enhancement

Run the tests on an --enable-pystats build as part of CI and/or buildbots.

Pitch

In #99701, it was discovered that the --enable-pystats build was broken by an unrelated change. No harm in that -- it's the usual unexpected interaction that happens all the time.

But if we want --enable-pystats to continue to work, we probably need to have some CI for it.

I don't feel super strongly about this -- every new bit of CI has a non-zero maintenance cost, and in this case there is a really small audience for collecting these sorts of stats (mainly those working on the specializing interpreter).

However, if there is enough interest, I did want to suggest it and offer my time to put it together.

@mdboom mdboom added type-feature A feature request or enhancement tests Tests in the Lib/test dir labels Nov 29, 2022
@corona10
Copy link
Member

corona10 commented Dec 11, 2022

Hi @mdboom cc @ericsnowcurrently @vstinner
I think that we need to add this feature for a specific purpose.
I am thinking about the following pipeline and I am going to work on if you don't mind I would like to assign the issue to myself.

Step 1: If the PR author adds the label bytecode-stats then execute step 2, if not stop at this stage.
Step 2: GitHub Action will be executed and the CPython will be built with --enable-pystats.
Step 3: Install pyperformance
Step 4: Run pyperformnace
Step 5: Collect bytecode execution stats.
Step 6: Send a comment to the bytecode execution stat through the PR comment.

By the suggested pipeline, the PR reviewer will be easier to analyze the effects of PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants