Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some deprecation warnings in Doc/conf.py #9

Merged
merged 2 commits into from Feb 11, 2017
Merged

Fix some deprecation warnings in Doc/conf.py #9

merged 2 commits into from Feb 11, 2017

Conversation

refi64
Copy link
Contributor

@refi64 refi64 commented Feb 11, 2017

crosses fingers (My crappy computer never finishes building the docs, so let's see how far Travis goes...)

@vstinner
Copy link
Member

I guess that it's related to my bug report http://bugs.python.org/issue29527

See also my PR #7.

@codecov
Copy link

codecov bot commented Feb 11, 2017

Codecov Report

Merging #9 into master will decrease coverage by -0.01%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   82.37%   82.37%   -0.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350948              
==========================================
- Hits       289090   289079      -11     
- Misses      61858    61869      +11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ab8be...d9c09b5. Read the comment docs.

@methane
Copy link
Member

methane commented Feb 11, 2017

Travis uses newest Sphinx.
But docs.python.org seems using sphinx-1.3.3. (see footer in https://docs.python.org/3/).

So changing latex_paper_size should be done after docs.python.org update.

@refi64
Copy link
Contributor Author

refi64 commented Feb 11, 2017

@methane latex_paper_size has been depreciated since Sphinx 0.5, when latex_elements was introduced. This shouldn't cause any problems unless someone has updated their Sphinx version since 2008.

Copy link
Member

@methane methane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Thanks.

@methane methane merged commit e7ffb99 into python:master Feb 11, 2017
Mariatta referenced this pull request in Mariatta/cpython Feb 14, 2017
* Fix some deprecation warnings in Doc/conf.py
* Fix an rst error in Misc/NEWS

Contributed by Ryan Gonzalez @kirbyfan64

(cherry picked from commit e7ffb99)
Mariatta referenced this pull request in Mariatta/cpython Feb 14, 2017
* Fix some deprecation warnings in Doc/conf.py
* Fix an rst error in Misc/NEWS

Contributed by Ryan Gonzalez @kirbyfan64

(cherry picked from commit e7ffb99)
Mariatta added a commit that referenced this pull request Feb 14, 2017
* Fix some deprecation warnings in Doc/conf.py
* Fix an rst error in Misc/NEWS

Contributed by Ryan Gonzalez @kirbyfan64

(cherry picked from commit e7ffb99)
Mariatta added a commit that referenced this pull request Feb 14, 2017
* Fix some deprecation warnings in Doc/conf.py
* Fix an rst error in Misc/NEWS

Contributed by Ryan Gonzalez @kirbyfan64

(cherry picked from commit e7ffb99)
native-api pushed a commit to native-api/cpython that referenced this pull request Jun 5, 2018
ethanhs added a commit to ethanhs/cpython that referenced this pull request Feb 5, 2020
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull request Sep 27, 2022
9: Warn for using built-in open r=ltratt a=nanjekyejoannah

Warn for file open. I was struggling to support the generic case assuming io.open doesnt exist.
A warning is simpler to do assuming support for >=2.6. I added notes in the Google doc for this.

Co-authored-by: Joannah Nanjekye <jnanjekye@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants