Objects/frameobject.c lacks error-checking

[Eclips4]

Bug report

Bug description:

There's a couple of moments like this:

cpython/Objects/frameobject.c

Lines 323 to 327 in d8d9491

	PyObject *dct = PyDict_New();
	PyObject *result = NULL;
	PyDict_Update(dct, self);
	result = PyObject_RichCompare(dct, other, op);
	Py_DECREF(dct);

Of course, we need to add a check that dct has a non-NULL value.

However, during the build I have notice this warning:

Objects/frameobject.c:390:59: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
framelocalsproxy_values(PyObject *self, PyObject *__unused)
                                                          ^

I think it's ok to address all of these issues in one PR.

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

Linked PRs

• gh-118609: Add proper error check for framelocalsproxy #118615

[Eclips4]

To fix the warning from the compiler we need to use Py_UNUSED, i.e PyObject *__unused -> PyObject *Py_UNUSED(ignored)

[gaogaotiantian]

Yeah, this is already fixed in my local PR. I'm waiting for the other one merged to create the PR to fix everything.

[gaogaotiantian]

The fix is merged.