Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test bleach_build_py #3

Closed
pquentin opened this issue Oct 28, 2018 · 4 comments
Closed

Test bleach_build_py #3

pquentin opened this issue Oct 28, 2018 · 4 comments

Comments

@pquentin
Copy link
Member

Okay, so we want to get to 100% coverage here: https://codecov.io/gh/RatanShreshtha/asyncbleach/src/master/asyncbleach/__init__.py. The next big step is to test bleach_build_py itself.

To do that, we'll need to write a project in the tests with a setup.py file, then call "python setup.py build", and see that the code did indeed get bleached.

Do you think you can work on that, @RatanShreshtha?

@RatanShreshtha
Copy link
Member

So I should created a simple hello world find of python project in tests and run python setup.py build ?

I think I can work on that. Can you suggest a minimalistic python project setup for that ?

@pquentin
Copy link
Member Author

I think we want a fake project in tests. For now we'll run python setup.py build manually, we'll worry about doing that from the tests later.

  1. You can read this setup.py documentation: https://packaging.python.org/tutorials/packaging-projects/ (other pages are useful too!)
  2. We'll also need a src directory: Move urllib3 to src/urllib3 urllib3/urllib3#1409 explains why with links to useful readings
  3. And we will want to use bleach_build_py: look at python-trio/urllib3 for that.

A PR even for the first item would be useful. As always feel free to ask questions.

@RatanShreshtha
Copy link
Member

So what should be the next thing for achieving coverage?

@pquentin
Copy link
Member Author

Two things left: actually use bleach_build_by, then run python setup.py build in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants