Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test on py 3.10 #327

Merged
merged 7 commits into from Jun 8, 2021
Merged

test on py 3.10 #327

merged 7 commits into from Jun 8, 2021

Conversation

graingert
Copy link
Member

No description provided.

@pquentin
Copy link
Member

pquentin commented Jun 8, 2021

I'm OK with removing Python 2.7 support, we can always use older versions of trustme for urllib3 1.x.

(But don't bother doing it here unless it actually helps.)

tests/test_trustme.py Outdated Show resolved Hide resolved
@graingert
Copy link
Member Author

@pquentin looks like codecov is broken?

@graingert graingert requested a review from pquentin June 8, 2021 13:40
@graingert graingert closed this Jun 8, 2021
@graingert graingert reopened this Jun 8, 2021
ci.sh Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #327 (6abfddd) into master (e3ac2d6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #327   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1160      1166    +6     
  Branches        48        48           
=========================================
+ Hits          1160      1166    +6     
Impacted Files Coverage Δ
trustme/tests/test_trustme.py 100.00% <0.00%> (ø)
a/trustme/trustme/tests/test_trustme.py 100.00% <0.00%> (ø)
.../runner/work/trustme/trustme/tests/test_trustme.py 100.00% <0.00%> (ø)

ci.sh Outdated Show resolved Hide resolved
@graingert graingert closed this Jun 8, 2021
@graingert graingert reopened this Jun 8, 2021
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wonder if dependabot will pick up the py3 requirements.

We'll need to update the classifiers, but that can happen in another PR.

@pquentin pquentin merged commit 8767902 into python-trio:master Jun 8, 2021
@graingert graingert deleted the test-on-py310 branch June 8, 2021 17:22
@pquentin
Copy link
Member

pquentin commented Jun 8, 2021

I released this as part of 0.8.0: https://pypi.org/project/trustme/0.8.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants