Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI breakage from pytest-cov 2.6.0 #646

Closed
njsmith opened this issue Sep 5, 2018 · 1 comment
Closed

CI breakage from pytest-cov 2.6.0 #646

njsmith opened this issue Sep 5, 2018 · 1 comment

Comments

@njsmith
Copy link
Member

njsmith commented Sep 5, 2018

Apparently the pytest-cov 2.6.0 release caused our CI to break: when we run coverage combine now, we get No data to combine and it errors out. Downgrading to pytest-cov 2.5.1 fixes things again (see #645), so that's the temporary workaround, but we should figure out how to get things working with 2.6.0.

This change is suspicious, since it touches coverage combine-related functionality: pytest-dev/pytest-cov#142
njsmith added a commit to njsmith/trio that referenced this issue Sep 5, 2018
@njsmith
[ci] Try skipping 'coverage combine' with new pytest-cov
876b75e 
Maybe this will solve python-triogh-646? Let's find out.
This was referenced Sep 5, 2018
Merged
Open
@njsmith
Copy link
Member Author

njsmith commented Sep 5, 2018

Tentatively closing this since #647 seems to have worked, but hopefully we'll get a definitive answer from upstream here: pytest-dev/pytest-cov#222

@njsmith njsmith closed this as completed Sep 5, 2018
@njsmith njsmith mentioned this issue Sep 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@njsmith