Remove the deprecated tiebreaker argument
#1858
Merged
+7
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1858 +/- ##
==========================================
+ Coverage 99.59% 99.62% +0.03%
==========================================
Files 114 114
Lines 14540 14523 -17
Branches 1111 1110 -1
==========================================
- Hits 14481 14469 -12
+ Misses 42 38 -4
+ Partials 17 16 -1
|
pquentin
force-pushed
the
remove-deprecated-tiebreaker
branch
from
0614a56 to
4e93f86
Compare
shamrin
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we have another
tiebreakervariable inself._heapbut I think it's unrelated and still useful.