Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triage tests from the CPython asyncio testsuite that trio-asyncio doesn't pass #67

Open
oremanj opened this issue Jan 11, 2020 · 0 comments

Comments

@oremanj
Copy link
Member

oremanj commented Jan 11, 2020

  • test_base_events.py::RunningLoopTests: test_running_loop_within_a_loop: hangs
  • test_base_events.py::BaseEventLoopWithSelectorTests: test_log_slow_callbacks: fails on 3.5 and 3.6
  • test_tasks.py::RunCoroutineThreadsafeTests:
    • test_run_coroutine_threadsafe_task_factory_exception: fails on 3.7 and 3.8
    • test_run_coroutine_threadsafe_task_cancelled: fails on 3.8
    • test_run_coroutine_threadsafe_with_timeout: fails on 3.8
  • test_events.py::FooEventLoopTests for each event loop type Foo supported by the platform:
    • test_create_ssl_connection, test_create_ssl_unix_connection: fails on Unix on older 3.7.x, older 3.6.x, and older-or-maybe-all 3.5.x
    • test_legacy_create_ssl_connection, test_legacy_create_ssl_unix_connection: same behavior but no problems on 3.7.x (possibly because the test is gone)
  • test_streams.py::StreamReaderTests (renamed to StreamTests on 3.7):
    • test_open_connection_no_loop_ssl, test_open_unix_connection_no_loop_ssl: same pattern as the create_ssl tests in the previous bullet

These are currently skipped or xfailed in tests/python/conftest.py. We should at minimum understand why they're failing. (I personally suspect that many of these are artifacts of the multi-thread approach we're using to support starting and stopping the loop multiple times.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant