Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExceptionGroup and fix magic-exception handling #130

Merged
merged 3 commits into from Nov 1, 2022

Conversation

Zac-HD
Copy link
Member

@Zac-HD Zac-HD commented Oct 30, 2022

Closes #104, closes #128. This is designed to be rebased on #129 so please review that first 馃檪

@Zac-HD Zac-HD force-pushed the use-exceptiongroup branch 6 times, most recently from 25b3b1b to 19d505e Compare October 31, 2022 17:31
@Zac-HD
Copy link
Member Author

Zac-HD commented Oct 31, 2022

OK, ready to go!

I'd also appreciate a release ASAP after this is merged; #104 means that @pytest.xfail(..., raise=SomeError) needs this patch to work with strict_exception_groups=True 馃槄

Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@Zac-HD Zac-HD merged commit 2ba99e6 into python-trio:master Nov 1, 2022
@Zac-HD Zac-HD deleted the use-exceptiongroup branch November 1, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants