Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch packaging from setup.py to pyproject.toml #4129

Open
harshil21 opened this issue Feb 23, 2024 · 0 comments
Open

Switch packaging from setup.py to pyproject.toml #4129

harshil21 opened this issue Feb 23, 2024 · 0 comments

Comments

@harshil21
Copy link
Member

harshil21 commented Feb 23, 2024

What kind of feature are you missing? Where do you notice a shortcoming of PTB?

PTB currently builds the wheels for uploading to PyPI by running the command python setup.py sdist bdist_wheel (from the wiki). However, the use of that command is deprecated.

The reason we are still using setup.py is because we wanted to dynamically build the wheels for both PTB and PTB-raw, and not have two separate repositories or files for that purpose. However, upon some observation, PTB has now made all its dependencies except httpx optional. This negates the need for having PTB-raw in the first place.

Additionally, the number of downloads for PTB-raw is tiny (12k/mo vs 1M/mo).

Describe the solution you'd like

Follow the packaging guide to migrate, and make sure that our build system follows the recommended guidelines. And then remove the PTB-raw package.

Describe alternatives you've considered

We could still keep setup.py, but we have to stop using that setup.py command to build wheels.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant