New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API 6.4 #3449
API 6.4 #3449
Conversation
Also add their tests
etc: Change a fixture scope to module, group WriteAccessAllowed test in a class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR, thanks for being so quick! In addition to a few specific comments:
- in
test_inputmedia.py
it would be good if we added a test toTestSendMediaGroup
about sending with spoiler - similar for
test_{photo, video, animation}
we already test spoilers in |
ah, no, I'm just blind :D |
# Conflicts: # telegram/_forumtopic.py
# Conflicts: # telegram/_files/inputmedia.py # telegram/ext/filters.py
New API update
Checklist for PRs
.. versionadded:: version
,.. versionchanged:: version
or.. deprecated:: version
to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)Added myself alphabetically toAUTHORS.rst
(optional)__all__
sIf the PR contains API changes (otherwise, you can delete this passage)
New classes:
self._id_attrs
and corresponding documentation__init__
acceptsapi_kwargs
as kw-onlyAdded new shortcuts:
Chat
&User
for all methods that acceptchat/user_id
Message
for all methods that acceptchat_id
andmessage_id
For newMessage
shortcuts: Addedquote
argument if methods acceptsreply_to_message_id
InCallbackQuery
for all methods that accept eitherchat_id
andmessage_id
orinline_message_id
If relevant:
Added new constants attelegram.constants
and shortcuts to them as class variablesAdd new message types toMessage.effective_attachment
Added new handlers for new update typesAdd the handlers to the warning loop in theConversationHandler
_extbot.py
bot_methods.rst
README.rst
andREADME_RAW.rst
(including the badge), as well astelegram.constants.BOT_API_VERSION_INFO
Added logic for arbitrary callback data intg.ext.Bot
for new methods that either accept areply_markup
in some form or have a return type that is/containstelegram.Message