Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: URL of code coverage - badge #3441

Merged
merged 2 commits into from Dec 26, 2022
Merged

Fix: URL of code coverage - badge #3441

merged 2 commits into from Dec 26, 2022

Conversation

Eisberge
Copy link
Contributor

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s

Intention

While admiring the badges, I noticed a regular hyperlink in the file README_RAW.rst instead of a badge.
The missing badge is the code coverage

Changes

The URL was different than the one in the README.rst and couldn't get resolved.

I copied the URL from README.rst, so they're equally now
(code coverage doesn't differentiate between python-telegram-bot and python-telegram-bot-raw).

github-actions[bot]
github-actions bot reviewed Dec 24, 2022
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

@Eisberge Eisberge changed the title Fixed badge of code coverage Fix: URL of code coverage - badge Dec 24, 2022
Poolitzer
Poolitzer approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is correct

@Bibo-Joshi Bibo-Joshi changed the base branch from master to doc-fixes December 26, 2022 10:04
@Bibo-Joshi Bibo-Joshi merged commit fa0642e into python-telegram-bot:doc-fixes Dec 26, 2022
@Bibo-Joshi
Copy link
Member

Thank you for the contribution :)

@Bibo-Joshi Bibo-Joshi mentioned this pull request Dec 26, 2022
Merged
4 tasks
Bibo-Joshi added a commit that referenced this pull request Jan 1, 2023
@Bibo-Joshi @lemontree210
@Viicos @harshil21 @Eisberge @zeshuaro
Documentation Improvements (#3428, #3423, #3429, #3441, #3404, #3443)
f408b1a 
Co-authored-by: Dmitry Kolomatskiy <58207913+lemontree210@users.noreply.github.com>
Co-authored-by: Viicos <65306057+Viicos@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Eisberge <22561095+Eisberge@users.noreply.github.com>
Co-authored-by: Joshua Tang <joshuaystang@gmail.com>
@harshil21 harshil21 added this to the v20.0 milestone Jan 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@Poolitzer Poolitzer Poolitzer approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
v20.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Eisberge @Bibo-Joshi @Poolitzer @harshil21