New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce code duplication in testing defaults handling #3419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm definitely for splitting up non-fixture things from conftest to this new directory. In fact, can you also extract the nested functions inside check_defaults_handling
into new functions (maybe in the same file)? Would make the code in there more readable at least
Those functions are nested because they work with several of the variables defined within |
@Bibo-Joshi hmm alright then I'm okay with it as is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I can verify if this works only after this is merged to master, but the tests passing here are a good indication it will.
Closes #3414. I double checked that tests do fail if any of the defaults-handling logic in
tg.Bot
is removed.get_me
after each assertion or even after checkingget_me
via mocking it.tests/auxil
with a filebot_methods_checks.py
in it where I moved the respective functions fromconftest.py
to. If this finds approval, I would move all other non-fixture things fromconf.py
into separate files withintests/auxil
.