Unified args and attrs in classes #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was not done completely in #3314 (`user` attr needed addition)
not sure this is correct in the attrs, but I'm not changing it: data (:obj:`str` | :obj:`object`) (it's only `str` in args)
* not sure I had to add the note for `invite_link` to args, but it is there in Telegram API * Telegram API contains no explicit limit for `name` arg/attr
lemontree210
commented
Dec 2, 2022
lemontree210
commented
Dec 2, 2022
maybe "Can't be a live location" and limit constants are not needed in attrs, but it matches Telegram API
`file_size` in attrs had wrong type too
lemontree210
commented
Dec 3, 2022
I didn't include Tip and ..seealso from `callback_data` argument as I assume it is not put into attrs on purpose
it's not really needed, but at least monospace font was in place, I think, so why not put a reference
from reading the docstr it isn't clear that it's a method of Bot
I think the 2nd part of docstring for `start_parameter` can be useful to understand this attr, despite the phrase addressing the generation of the Invoice
Bibo-Joshi
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
I looked through everything (maybe not every single word :D) and tbh I didn't find anything to complain about 🙆♂️ You've been very thorough - also with keeping #3109 (comment) up to date 🤯
It makes sense in attrs but not in args
lemontree210
commented
Dec 23, 2022
Bibo-Joshi
added a commit
that referenced
this pull request
Jan 1, 2023
Co-authored-by: Dmitry Kolomatskiy <58207913+lemontree210@users.noreply.github.com> Co-authored-by: Viicos <65306057+Viicos@users.noreply.github.com> Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com> Co-authored-by: Eisberge <22561095+Eisberge@users.noreply.github.com> Co-authored-by: Joshua Tang <joshuaystang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3109
changes for
DiceandLoginUrlreflect those in a closed PR #3316