New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warning to install optional dependencies #3393
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes themself look got to me 👍
- pre-commit is complaining a bit. If you run
pre-commit install
locally, the pre-commit hooks will run before you can commit - We'll need a test to ensure that the warning is issued as expected, i.e. the warning is there, the messages is the expected one and the warning points the user to the line where
context.job_queue
is accessed. You can e.g. have a look atTestJobQueue.test_run_daily
for some inspiration on how that can be done :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stylistic suggestions below.
Also the more likely scenario is when user does application.job_queue.run_*
and faces an error. Shouldn't we make that a property to raise this warning as well?
I guess it's hard to say if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
-
TestConversationHandler.test_no_running_job_queue_warning
currently fails b/c it's trying to overrideapp.job_queue
. Maybe it's best to build a newApplication
instance in that test, i.e. something likeif not jq: app = ApplicationBuilder().token(bot.token).job_queue(None)
-
similar for
TestConversationHandler.test_schedule_job_exception
: here one would doAB().token(…).job_queue(DictJQ())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay I'm not sure why Github is not showing me the changes in conversationhandler.py in the files changed tab, but I think you should replace all instances of application.job_queue
with application._job_queue
to avoid unintentionally raising a warning in user code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty to tie up the very last loose ends :) I'm happy now. If harshil is as well, we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #3391