Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 5.5 #2809

Merged
merged 12 commits into from Dec 11, 2021
Merged

Api 5.5 #2809

merged 12 commits into from Dec 11, 2021

Conversation

Bibo-Joshi
Copy link
Member

@Bibo-Joshi Bibo-Joshi commented Dec 7, 2021

closes #2808

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs

If the PR contains API changes (otherwise, you can delete this passage)

  • New classes:

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts **_kwargs
  • Added new shortcuts:

    • In Chat & User for all methods that accept chat/user_id
    • In Message for all methods that accept chat_id and message_id
    • For new Message shortcuts: Added quote argument if methods accepts reply_to_message_id
    • In CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id
  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION
    • Added logic for arbitrary callback data in tg.ext.Bot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

@Bibo-Joshi Bibo-Joshi added the API label Dec 7, 2021
telegram/chatjoinrequest.py Outdated Show resolved Hide resolved
telegram/inline/inlinekeyboardbutton.py Outdated Show resolved Hide resolved
telegram/user.py Outdated Show resolved Hide resolved
@harshil21 harshil21 linked an issue Dec 8, 2021 that may be closed by this pull request
8 tasks
telegram/bot.py Outdated Show resolved Hide resolved
telegram/bot.py Show resolved Hide resolved
telegram/bot.py Outdated Show resolved Hide resolved
telegram/chat.py Show resolved Hide resolved
telegram/ext/filters.py Show resolved Hide resolved
telegram/message.py Outdated Show resolved Hide resolved
tests/test_bot.py Outdated Show resolved Hide resolved
Copy link
Member Author

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IISC apart from the open comments, only updating the API version is missing, right?

telegram/inline/inlinekeyboardbutton.py Outdated Show resolved Hide resolved
tests/test_bot.py Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

Copy link
Member

@Poolitzer Poolitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Bibo-Joshi Bibo-Joshi merged commit cb95868 into master Dec 11, 2021
@Bibo-Joshi Bibo-Joshi deleted the api-5.5 branch December 11, 2021 14:22
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API] Api 5.5
3 participants