Catch exceptions raised while copying __dict__/__slots__ in BasePersi…

[zeroone2numeral2]

…stence.replace/insert_bot()

Also updated the docstrings to reflect the changes in behavior with unexpected errors

closes #2563

Checklist for PRs

• Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
• Created new or adapted existing unit tests
• Added myself alphabetically to AUTHORS.rst (optional)

[zeroone2numeral2]

I was looking at the contribution guidelines. Quiting:

Add .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the associated documentation of your changes, depending on what kind of change you made. This only applies if the change you made is visible to an end user. The directives should be added to class/method descriptions if their general behaviour changed and to the description of all arguments & attributes that changed.

I did made some changes to the docstring of the replace_bot and insert_bot methods, so I built the docs and looked for their docs source. But I can't find any versionchanged string. I'm not sure if I'm supposed to do something or not

[zeroone2numeral2]

Question about tests: I've added a uuid.UUID object to CustomClass, which is immutable and would raise a TypeError in insert/replace_bot. I tried to run the tests as described in the contributions guidelines with pytest -v, but I'm a bit lost: the test for test_persistence.py failed with the following output: https://nekobin.com/loqazeruxi

I'm not entirely sure how I should update the test

Edit: it fails even after 9e67463

[Bibo-Joshi]

Thanks for the PR!

Regarding docstrings: Those look fine, shouldn't be a problem to build them 👌
Regarding tests: I forgot that pytest treats warnings as errors if not handled otherwise … On a closer look I see that we have a for unpickable objects test here. You can copy that and replace lock with uuid (you can skip the CustomClass part and revert your current changes to the tests)

Also, pre-commit complains about a few things. Please make sure to run pre-commit install on your machine so that pre-commit can run on every commit. You can also have it run manually via pre-commit run. Have a look at the contribution guide for more details :)

[Bibo-Joshi]

Except for the typo, this looks good to me :)

[Bibo-Joshi]

Thanks for the contribution @zeroone2numeral2 :)

[zeroone2numeral2]

Thanks @harshil21 for the commit! I've been busy during the weekend

And thanks for the merge :)