Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated arg from deeplinking.py #2550

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Conversation

harshil21
Copy link
Member

@harshil21 harshil21 commented Jun 6, 2021

for some reason pass_args=True was still being passed to a CommandHandler

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

@Bibo-Joshi
Copy link
Member

Maybe we can do this together with #2346?

@harshil21 harshil21 added this to the v14 milestone Jun 7, 2021
@harshil21 harshil21 added this to Stage 1: Clean-Up | First things first in v20 Jun 7, 2021
@Poolitzer
Copy link
Member

Poolitzer commented Jun 7, 2021

I dont see the need, ou contraire. This example throws a warning, we should merge this asap to avoid bad code examples.

@Bibo-Joshi Bibo-Joshi merged commit d08172b into master Jun 7, 2021
@Bibo-Joshi Bibo-Joshi deleted the rm-deprecated-arg branch June 7, 2021 07:05
sakibguy added a commit to sakibguy/python-telegram-bot that referenced this pull request Jun 8, 2021
Remove Deprecated pass_args from Deeplinking Example (python-telegram-bot#2550)
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2021
@Bibo-Joshi Bibo-Joshi removed this from Stage 1: Clean-Up | First things first in v20 Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants