Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pattern arg to ChosenInlineResultHandler #2517

Merged
merged 6 commits into from
May 19, 2021
Merged

Add pattern arg to ChosenInlineResultHandler #2517

merged 6 commits into from
May 19, 2021

Conversation

Poolitzer
Copy link
Member

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)

  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION

This PR closes #2516

@Poolitzer Poolitzer added this to the v13.6 milestone May 13, 2021
@Poolitzer
Copy link
Member Author

I have no idea why codecov/patch fails.

@Poolitzer
Fix: remove unnecessary if clause
930f40e 
the attribute must be present, since it's not optional.
Bibo-Joshi
Bibo-Joshi requested changes May 14, 2021
View reviewed changes
Copy link
Member

@Bibo-Joshi Bibo-Joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! Just a bit of nitpicking :)

telegram/ext/choseninlineresulthandler.py Show resolved Hide resolved
telegram/ext/choseninlineresulthandler.py Outdated Show resolved Hide resolved
telegram/ext/choseninlineresulthandler.py Outdated Show resolved Hide resolved
tests/test_choseninlineresulthandler.py Outdated Show resolved Hide resolved
harshil21
harshil21 reviewed May 14, 2021
View reviewed changes
Copy link
Member

@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice change.

telegram/ext/choseninlineresulthandler.py Outdated Show resolved Hide resolved
Poolitzer and others added 2 commits May 19, 2021 09:59
@Poolitzer @Bibo-Joshi
Fix: wrong type documentation
f31d0f1 
Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de>
@Poolitzer
Fix: Addressing code review
c91bcdd 
small documentation fixes, and moving one test.
Poolitzer and others added 2 commits May 19, 2021 10:10
@Poolitzer @Bibo-Joshi
Fix: link to matches
23d4362 
Co-authored-by: Bibo-Joshi <hinrich.mahler@freenet.de>
@Poolitzer
Fix: also link here
8f74bf0
@Bibo-Joshi Bibo-Joshi merged commit 8b0d2e5 into master May 19, 2021
@Bibo-Joshi Bibo-Joshi deleted the chosen_inline_handler_pattern branch May 19, 2021 08:32
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshil21 harshil21 harshil21 left review comments

@Bibo-Joshi Bibo-Joshi Bibo-Joshi approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v13.6
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a pattern for result_id of ChosenInlineResultHandler
3 participants
@Poolitzer @Bibo-Joshi @harshil21