-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supplement Codacy with DeepSource #2454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)
DeepSource indeed found a number of things that can be improved. Large parts of those are "just" documentation improvements according to the google style guide, but since actually "officially" adhere to those (meaning: we say so in the contrib guide), I think this is a good opportunity to actually do so. I'll try & make the corresponding changes in the near future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
Resolved issues in the following files via DeepSource Autofix: 1. tests/conftest.py 2. tests/test_bot.py 3. tests/test_commandhandler.py 4. tests/test_conversationhandler.py 5. tests/test_dispatcher.py 6. tests/test_filters.py 7. tests/test_inputmedia.py 8. tests/test_messagehandler.py 9. tests/test_official.py 10. tests/test_persistence.py
# Conflicts: # telegram/bot.py # telegram/ext/conversationhandler.py # telegram/ext/filters.py # telegram/utils/webhookhandler.py
# Conflicts: # tests/test_updater.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me, great job for adding all those missing docs 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good changes, specially the docs for TelegramError
and TelegramObject
, we needed that! The tests shall finally succeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this PR, changes look good
Before merging:
Some notes:
Days
inJobQueue
, as we don't really use it.