From 26e000f4a156ff0333389697f7c30ebdf31a2a61 Mon Sep 17 00:00:00 2001 From: "Edward K. Ream" Date: Sun, 27 Nov 2022 02:57:45 -0600 Subject: [PATCH 1/2] Remove pyflakes complaints in four unit tests --- ropetest/refactor/patchedasttest.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/ropetest/refactor/patchedasttest.py b/ropetest/refactor/patchedasttest.py index dfebc4737..7dc2fda17 100644 --- a/ropetest/refactor/patchedasttest.py +++ b/ropetest/refactor/patchedasttest.py @@ -127,30 +127,32 @@ def test_assign_node(self): source = "a = 10\n" ast_frag = patchedast.get_patched_ast(source, True) checker = _ResultChecker(self, ast_frag) - start = source.index("a") # noqa + start = source.index("a") checker.check_region("Assign", 0, len(source) - 1) checker.check_children("Assign", ["Name", " ", "=", " ", "Num"]) + self.assertTrue(start is not None) @testutils.only_for_versions_higher("3.6") def test_ann_assign_node_without_target(self): source = "a: List[int]\n" ast_frag = patchedast.get_patched_ast(source, True) checker = _ResultChecker(self, ast_frag) - start = source.index("a") # noqa + start = source.index("a") checker.check_region("AnnAssign", 0, len(source) - 1) checker.check_children("AnnAssign", ["Name", "", ":", " ", "Subscript"]) + self.assertTrue(start is not None) @testutils.only_for_versions_higher("3.6") def test_ann_assign_node_with_target(self): source = "a: int = 10\n" ast_frag = patchedast.get_patched_ast(source, True) checker = _ResultChecker(self, ast_frag) - start = source.index("a") # noqa + start = source.index("a") checker.check_region("AnnAssign", 0, len(source) - 1) checker.check_children( "AnnAssign", ["Name", "", ":", " ", "Name", " ", "=", " ", "Num"] ) - + self.assertTrue(start is not None) def test_add_node(self): source = "1 + 2\n" ast_frag = patchedast.get_patched_ast(source, True) @@ -375,9 +377,10 @@ def test_aug_assign_node(self): source = "a += 1\n" ast_frag = patchedast.get_patched_ast(source, True) checker = _ResultChecker(self, ast_frag) - start = source.index("a") # noqa + start = source.index("a") checker.check_region("AugAssign", 0, len(source) - 1) checker.check_children("AugAssign", ["Name", " ", "+", "", "=", " ", "Num"]) + self.assertTrue(start is not None) @testutils.only_for_versions_lower("3") def test_back_quotenode(self): From a8b91cd7f4f59adec4f8a11bb9af06dbe7aac27b Mon Sep 17 00:00:00 2001 From: Lie Ryan Date: Sun, 27 Nov 2022 23:59:00 +1100 Subject: [PATCH 2/2] Remove unused variable in test There's basically no good reasons for these variables to exist. --- ropetest/refactor/patchedasttest.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/ropetest/refactor/patchedasttest.py b/ropetest/refactor/patchedasttest.py index 7dc2fda17..25298c453 100644 --- a/ropetest/refactor/patchedasttest.py +++ b/ropetest/refactor/patchedasttest.py @@ -105,7 +105,6 @@ def test_integer_literals_and_sorted_children(self): source = "a = 10\n" ast_frag = patchedast.get_patched_ast(source, True) checker = _ResultChecker(self, ast_frag) - # start = source.index('10') checker.check_children("Num", ["10"]) def test_ellipsis(self): @@ -127,32 +126,27 @@ def test_assign_node(self): source = "a = 10\n" ast_frag = patchedast.get_patched_ast(source, True) checker = _ResultChecker(self, ast_frag) - start = source.index("a") checker.check_region("Assign", 0, len(source) - 1) checker.check_children("Assign", ["Name", " ", "=", " ", "Num"]) - self.assertTrue(start is not None) @testutils.only_for_versions_higher("3.6") def test_ann_assign_node_without_target(self): source = "a: List[int]\n" ast_frag = patchedast.get_patched_ast(source, True) checker = _ResultChecker(self, ast_frag) - start = source.index("a") checker.check_region("AnnAssign", 0, len(source) - 1) checker.check_children("AnnAssign", ["Name", "", ":", " ", "Subscript"]) - self.assertTrue(start is not None) @testutils.only_for_versions_higher("3.6") def test_ann_assign_node_with_target(self): source = "a: int = 10\n" ast_frag = patchedast.get_patched_ast(source, True) checker = _ResultChecker(self, ast_frag) - start = source.index("a") checker.check_region("AnnAssign", 0, len(source) - 1) checker.check_children( "AnnAssign", ["Name", "", ":", " ", "Name", " ", "=", " ", "Num"] ) - self.assertTrue(start is not None) + def test_add_node(self): source = "1 + 2\n" ast_frag = patchedast.get_patched_ast(source, True)