Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Field refactoring allows you to rename a local field with the method name #766

Closed
Tracked by #779
jonhnanthan opened this issue Feb 27, 2024 · 1 comment
Closed
Tracked by #779

Comments

@jonhnanthan
Copy link

Rename Field refactoring allows the use of the name of the recursive method in the field inside the same method.
It would be nice if Rope could emit an alert to the user to confirm the operation to avoid type errors

Steps to reproduce the behavior:

  1. Code before refactoring:
def pluralize(word, pos="NN", custom={}, classical=True):
    if word.endswith("'"):
        owners = pluralize(word.rstrip("'s"), pos, custom, classical)
        if owners.endswith("s"):
            return owners + "'"

    words = word.replace("-", " ").split(" ")
    return word.replace(words[0], pluralize(words[0], pos, custom, classical))
  1. Apply the Rename Field refactoring with the new name 'pluralize' to the 'owners' field.
@jonhnanthan jonhnanthan added the bug Unexpected or incorrect user-visible behavior label Feb 27, 2024
@lieryan
Copy link
Member

lieryan commented Mar 12, 2024

Closing. Ticket merged into #779.

@lieryan lieryan closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
@lieryan lieryan added enhancement and removed bug Unexpected or incorrect user-visible behavior labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants