Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate the confusing import in pyobjectsdef.py #569

Closed
2 tasks done
edreamleo opened this issue Dec 5, 2022 · 3 comments
Closed
2 tasks done

Eliminate the confusing import in pyobjectsdef.py #569

edreamleo opened this issue Dec 5, 2022 · 3 comments

Comments

@edreamleo
Copy link
Contributor

edreamleo commented Dec 5, 2022 •
edited

In pyobjectsdef.py:

  • Replace:
from rope.base import (
    pynamesdef as pynames,
    ...

with:

from rope.base import (
    pynamesdef,
    ...
  • Replace pynames with pynamesdef everywhere in pyobjectsdef.py.

The name pynamesdef appears nowhere else in pyobjectsdef.py, so the proposed renaming is safe.
@lieryan
Copy link
Member

lieryan commented Dec 5, 2022

+1, yes, this should be done

@edreamleo
Copy link
Contributor Author

@lieryan Thanks!

@edreamleo edreamleo mentioned this issue Dec 5, 2022
Merged
lieryan pushed a commit that referenced this issue Dec 5, 2022
@edreamleo
PR for #569: rename pynames to pynamesdef in pyobjectsdef.ph (#572)
129d761 
Rename pyobjects to pyobjectsdef
@lieryan lieryan closed this as completed Dec 5, 2022
@edreamleo
Copy link
Contributor Author

@lieryan My pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@edreamleo @lieryan