Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some python2-isms #555

Merged
merged 4 commits into from Nov 28, 2022
Merged

Fix some python2-isms #555

merged 4 commits into from Nov 28, 2022

Conversation

lieryan
Copy link
Member

@lieryan lieryan commented Nov 28, 2022

Fix a number of python2-ism

Fix #542 and others

This was remnant when we were using `unittest`; now no longer necessary
because we now uses `pytest`, as well as `unittest` now have
`discover()` anyway.
Done using:

    $ pyupgrade --py36-plus
@lieryan lieryan added the cleanup Code quality issues. Linter, type checking, Python 2-ism, Pythonic, etc label Nov 28, 2022
@lieryan lieryan added this to the 1.6.0 milestone Nov 28, 2022
@lieryan lieryan self-assigned this Nov 28, 2022
@lieryan lieryan merged commit 768f95a into master Nov 28, 2022
@lieryan lieryan deleted the lieryan-fix-python2-isms branch November 28, 2022 16:20
Copy link
Contributor

@edreamleo edreamleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality issues. Linter, type checking, Python 2-ism, Pythonic, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use fstrings
2 participants