Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to inline dictionary with inline comment #514

Closed
lieryan opened this issue Oct 28, 2022 · 0 comments · Fixed by #527
Closed

Fail to inline dictionary with inline comment #514

lieryan opened this issue Oct 28, 2022 · 0 comments · Fixed by #527
Assignees
Labels
bug Unexpected or incorrect user-visible behavior inline-refactor
Milestone

Comments

@lieryan
Copy link
Member

lieryan commented Oct 28, 2022

Fail to inlining code with inline comment.

To Reproduce
Steps to reproduce the behavior:

  1. Code before refactoring:
myvar = {
    "key": "value",  # noqa
}
print(myvar)
  1. Describe the refactoring you want to do: Inline "myvar"

  2. Expected code after refactoring:


print({
    "key": "value",  # noqa
})
  1. Describe the error or unexpected result that you are getting
Syntax error in file <tests/test_debug_application_credential.py> line <1>: '{' was never closed

Editor information (please complete the following information):

  • Project Python version: 3.10.6
  • Rope Python version: 3.10.6
  • Rope version: rope==1.4.0
  • Text editor/IDE and version: Vim
@lieryan lieryan added bug Unexpected or incorrect user-visible behavior inline-refactor labels Oct 28, 2022
@lieryan lieryan added this to the 1.5.0 milestone Oct 28, 2022
@lieryan lieryan self-assigned this Oct 28, 2022
@lieryan lieryan changed the title Fail to inlining dictionary with inline comment Fail to inline dictionary with inline comment Oct 28, 2022
lieryan added a commit that referenced this issue Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected or incorrect user-visible behavior inline-refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant