Fix variable scope issue when renaming list comprehension variables (#293) #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieryan
reviewed
Oct 8, 2021
ropetest/refactor/renametest.py
Outdated
| @@ -41,138 +41,170 @@ def test_simple_global_variable_renaming(self): | |||
|
|
|||
| def test_variable_renaming_only_in_its_scope(self): | |||
| refactored = self._local_rename( | |||
| dedent("""\ | |||
| dedent( | |||
| """\ | |||
There was a problem hiding this comment.
Hi @climbus, I think these reformattings should not be made here. There is a setting in pyproject.toml that tells black that it should not be reformatting files in ropetest folder.
Can you modify your editor/black settings to make sure that it honors the pyproject.toml setting and revert these reformatting changes.
Thanks.
|
I was thinking why it happens to me ;) Thanks. I fixed it. |
lieryan
changed the title
|
Hi @climbus massive thank you and congratulations for fixing this issue. It had been quite a complex issue to fix this. |
No problem. I was interesting challenge ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finally, fixed issue #293
Checklist (delete if not relevant):