Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_holding_scope_for_offset gets scope by offset not a line #426

Merged
merged 8 commits into from Oct 3, 2021
Merged

get_holding_scope_for_offset gets scope by offset not a line #426

merged 8 commits into from Oct 3, 2021

Conversation

climbus
Copy link
Contributor

@climbus climbus commented Oct 2, 2021

Description

Part of #293.

Checklist (delete if not relevant):

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated CHANGELOG.md

@lieryan
Copy link
Member

lieryan commented Oct 3, 2021

Hi @climbus, thank you for implementing this. This is great.

@lieryan lieryan merged commit fb4bdc3 into python-rope:master Oct 3, 2021
@climbus climbus mentioned this pull request Oct 6, 2021
Merged
1 task
@lieryan lieryan added this to the 0.21.x milestone Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.21.x
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@climbus @lieryan