Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprhensions with scope #422

Merged
merged 16 commits into from Sep 28, 2021
Merged

Conversation

climbus
Copy link
Contributor

@climbus climbus commented Sep 27, 2021

Description

Added scope for comprehension expressions
Part of #293

Checklist (delete if not relevant):

  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] I have updated CHANGELOG.md



if __name__ == "__main__":
unittest.main()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are using pytest now, it is no longer necessary to create these Test Suites and main() constructs.

@lieryan
Copy link
Member

lieryan commented Sep 28, 2021

Hi @climbus, thank you, this is really great work.

@lieryan lieryan merged commit d6f809e into python-rope:master Sep 28, 2021
@lieryan lieryan added this to the 0.21.x milestone Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants