Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code with black and add check on push #399

Closed
climbus opened this issue Sep 19, 2021 · 1 comment · Fixed by #404
Closed

Reformat code with black and add check on push #399

climbus opened this issue Sep 19, 2021 · 1 comment · Fixed by #404
Milestone

Comments

@climbus
Copy link
Contributor

climbus commented Sep 19, 2021

Can We reformat code with black?

I've checked on my fork and looks that everything is ok. Of course We must have cleat situation with branches and merging.

https://github.com/climbus/rope/actions/runs/1250987372

@lieryan
Copy link
Member

lieryan commented Sep 26, 2021

Hi @climbus,

Thanks for bringing this up. I wasn't able to use your branch as-is, so I've re-ran black and made a new commit instead. I have git attribute you as the commit author when making the commit to credit you for bringing this topic up and for doing the original blackening. I hope you don't mind.

@lieryan lieryan added this to the 0.21.x milestone Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants