Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoted curly braces identifier in f-string is not properly replaced #303

Closed
mlao-pdx opened this issue Aug 13, 2020 · 3 comments · Fixed by #420
Closed

Quoted curly braces identifier in f-string is not properly replaced #303

mlao-pdx opened this issue Aug 13, 2020 · 3 comments · Fixed by #420
Assignees
Labels
affected-version:0.19 bug Unexpected or incorrect user-visible behavior rename-refactor
Milestone

Comments

@mlao-pdx
Copy link

mlao-pdx commented Aug 13, 2020

# Refactor issue -> bug
issue = "Rope inserts after first character of replacement instead replacing when quoted in f-strings."

# Failing examples will look like {ibugssue}
success = f" {issue} "
bug_example_1 = f" '{issue}' "
bug_example_2 = f""" "{issue}" """
bug_example_3 = f' "{issue}" '
@chrisjsewell
Copy link

hey yeh I'm really surprised more people haven't commented on this.
I use f-strings all the time, and it makes rope really horrible to use in the current state

@lieryan lieryan added bug Unexpected or incorrect user-visible behavior rename-refactor labels Sep 5, 2021
@lieryan lieryan added this to the 0.20.0 milestone Sep 5, 2021
@lieryan lieryan modified the milestones: 0.20.0, 0.21.0 Sep 12, 2021
@lieryan lieryan self-assigned this Sep 25, 2021
@lieryan
Copy link
Member

lieryan commented Sep 27, 2021

@mlao-pdx Thank you for reporting this bug, this has now been fixed in master and will be part of 0.21 release.

@mlao-pdx
Copy link
Author

Awesome, thanks @lieryan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected-version:0.19 bug Unexpected or incorrect user-visible behavior rename-refactor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants