Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When inlining function allow comparisons in arguments #245

Merged

Conversation

brendanator
Copy link
Contributor

When inlining a_func

def a_func(param1, param2, param3):
    param2.name
a_func(2 <= 1, item, True)

the current result is True.name.

This is because the 2<= 1 argument is treated as a keyword argument and so the True argument becomes param2

This PR includes a fix to worder so it understands comparisons are not keyword arguments

@soupytwist soupytwist added the bug Unexpected or incorrect user-visible behavior label Jun 25, 2018
@soupytwist
Copy link
Contributor

Thank you for the fix!

@soupytwist soupytwist merged commit 0df2190 into python-rope:master Jun 25, 2018
@brendanator brendanator deleted the inline-comparison-arguments branch July 5, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected or incorrect user-visible behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants