Generating class in other module. #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soupytwist
reviewed
Mar 14, 2018
| @@ -42,15 +42,16 @@ def create_package(project, name, sourcefolder=None): | |||
|
|
|||
| class _Generate(object): | |||
|
|
|||
| def __init__(self, project, resource, offset): | |||
| def __init__(self, project, resource, offset, goal_resource=None): | |||
There was a problem hiding this comment.
It should be invalid for GenerateModule or GeneratePackage, there's nothing additional to do for these. However, being as they override get_changes, maybe this doesn't matter since it would just be ignored.
There was a problem hiding this comment.
I admit that it is poor style to declare fields in parent class that are not used in child class. I have chosen it because it needs the smallest changes.
As an alternative I could change hierarchy so that it would look something like:
- _ModuleElementGenerate(_Generate)
- GenerateClass(_ModuleElementGenerate)
- GenerateFunction(_ModuleElementGenerate)
- GenerateVariable(_ModuleElementGenerate)
- GenerateModule(_Generate)
- GeneratePackage(_Generate)
Should I change it?
There was a problem hiding this comment.
No, I agree it's better as-is, and won't cause any harm. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds ability to generate class in module other than current.