Bugfix for detecting pynames in aliased import statements #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case wasn't being handled correctly; e.g, the pyname for "foo" in `import foo as bar` evaluates to an `AssignedName` instead of an `ImportedModule`. This is similar to the module name in a "from" import, adding a special case to handle it in the same way.
|
@mcepl, want to take a look? Good to have another pair of eyes on it. |
|
Looks reasonable. I cannot vouch for the code, because I really forgot most of Rope API, but I don't see anything obviously stupid and there are tests, so it should be OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This case wasn't being handled correctly; e.g, the pyname for "foo" in
import foo as barevaluates to anAssignedNameinstead of anImportedModule. This is similar to the module name in a "from" import,adding a special case to handle it in the same way.
Fixes #229