-
Notifications
You must be signed in to change notification settings - Fork 161
/
inlinetest.py
713 lines (617 loc) · 29.5 KB
/
inlinetest.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
from textwrap import dedent
try:
import unittest2 as unittest
except ImportError:
import unittest
import rope.base.exceptions
from rope.refactor import inline
from ropetest import testutils
class InlineTest(unittest.TestCase):
def setUp(self):
super(InlineTest, self).setUp()
self.project = testutils.sample_project()
self.pycore = self.project.pycore
self.mod = testutils.create_module(self.project, "mod")
self.mod2 = testutils.create_module(self.project, "mod2")
def tearDown(self):
testutils.remove_project(self.project)
super(InlineTest, self).tearDown()
def _inline(self, code, offset, **kwds):
self.mod.write(code)
self._inline2(self.mod, offset, **kwds)
return self.mod.read()
def _inline2(self, resource, offset, **kwds):
inliner = inline.create_inline(self.project, resource, offset)
changes = inliner.get_changes(**kwds)
self.project.do(changes)
return self.mod.read()
def test_simple_case(self):
code = "a_var = 10\nanother_var = a_var\n"
refactored = self._inline(code, code.index("a_var") + 1)
self.assertEqual("another_var = 10\n", refactored)
def test_empty_case(self):
code = "a_var = 10\n"
refactored = self._inline(code, code.index("a_var") + 1)
self.assertEqual("", refactored)
def test_long_definition(self):
code = "a_var = 10 + (10 + 10)\nanother_var = a_var\n"
refactored = self._inline(code, code.index("a_var") + 1)
self.assertEqual("another_var = 10 + (10 + 10)\n", refactored)
def test_explicit_continuation(self):
code = "a_var = (10 +\n 10)\nanother_var = a_var\n"
refactored = self._inline(code, code.index("a_var") + 1)
self.assertEqual("another_var = (10 + 10)\n", refactored)
def test_implicit_continuation(self):
code = "a_var = 10 +\\\n 10\nanother_var = a_var\n"
refactored = self._inline(code, code.index("a_var") + 1)
self.assertEqual("another_var = 10 + 10\n", refactored)
def test_inlining_at_the_end_of_input(self):
code = "a = 1\nb = a"
refactored = self._inline(code, code.index("a") + 1)
self.assertEqual("b = 1", refactored)
def test_on_classes(self):
code = "class AClass(object):\n pass\n"
with self.assertRaises(rope.base.exceptions.RefactoringError):
self._inline(code, code.index("AClass") + 1)
def test_multiple_assignments(self):
code = "a_var = 10\na_var = 20\n"
with self.assertRaises(rope.base.exceptions.RefactoringError):
self._inline(code, code.index("a_var") + 1)
def test_tuple_assignments(self):
code = "a_var, another_var = (20, 30)\n"
with self.assertRaises(rope.base.exceptions.RefactoringError):
self._inline(code, code.index("a_var") + 1)
def test_on_unknown_vars(self):
code = "a_var = another_var\n"
with self.assertRaises(rope.base.exceptions.RefactoringError):
self._inline(code, code.index("another_var") + 1)
def test_attribute_inlining(self):
code = (
"class A(object):\n def __init__(self):\n"
" self.an_attr = 3\n range(self.an_attr)\n"
)
refactored = self._inline(code, code.index("an_attr") + 1)
expected = "class A(object):\n def __init__(self):\n" " range(3)\n"
self.assertEqual(expected, refactored)
def test_attribute_inlining2(self):
code = (
"class A(object):\n def __init__(self):\n"
" self.an_attr = 3\n range(self.an_attr)\n"
"a = A()\nrange(a.an_attr)"
)
refactored = self._inline(code, code.index("an_attr") + 1)
expected = (
"class A(object):\n def __init__(self):\n"
" range(3)\n"
"a = A()\nrange(3)"
)
self.assertEqual(expected, refactored)
def test_a_function_with_no_occurance(self):
self.mod.write("def a_func():\n pass\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("", self.mod.read())
def test_a_function_with_no_occurance2(self):
self.mod.write("a_var = 10\ndef a_func():\n pass\nprint(a_var)\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("a_var = 10\nprint(a_var)\n", self.mod.read())
def test_replacing_calls_with_function_definition_in_other_modules(self):
self.mod.write("def a_func():\n print(1)\n")
mod1 = testutils.create_module(self.project, "mod1")
mod1.write("import mod\nmod.a_func()\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("import mod\nprint(1)\n", mod1.read())
def test_replacing_calls_with_function_definition_in_other_modules2(self):
self.mod.write("def a_func():\n print(1)\n")
mod1 = testutils.create_module(self.project, "mod1")
mod1.write("import mod\nif True:\n mod.a_func()\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("import mod\nif True:\n print(1)\n", mod1.read())
def test_replacing_calls_with_method_definition_in_other_modules(self):
self.mod.write(
"class A(object):\n var = 10\n"
" def a_func(self):\n print(1)\n"
)
mod1 = testutils.create_module(self.project, "mod1")
mod1.write("import mod\nmod.A().a_func()\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("import mod\nprint(1)\n", mod1.read())
self.assertEqual("class A(object):\n var = 10\n", self.mod.read())
def test_replacing_calls_with_function_definition_in_defining_module(self):
self.mod.write("def a_func():\n print(1)\na_func()\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("print(1)\n", self.mod.read())
def test_replac_calls_with_function_definition_in_defining_module2(self):
self.mod.write(
"def a_func():\n " "for i in range(10):\n print(1)\na_func()\n"
)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("for i in range(10):\n print(1)\n", self.mod.read())
def test_replacing_calls_with_method_definition_in_defining_modules(self):
self.mod.write(
"class A(object):\n var = 10\n"
" def a_func(self):\n print(1)\nA().a_func()"
)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("class A(object):\n var = 10\nprint(1)\n", self.mod.read())
def test_parameters_with_the_same_name_as_passed(self):
self.mod.write("def a_func(var):\n " "print(var)\nvar = 1\na_func(var)\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("var = 1\nprint(var)\n", self.mod.read())
def test_parameters_with_the_same_name_as_passed2(self):
self.mod.write(
"def a_func(var):\n " "print(var)\nvar = 1\na_func(var=var)\n"
)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("var = 1\nprint(var)\n", self.mod.read())
def test_simple_parameters_renaming(self):
self.mod.write(
"def a_func(param):\n " "print(param)\nvar = 1\na_func(var)\n"
)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("var = 1\nprint(var)\n", self.mod.read())
def test_simple_parameters_renaming_for_multiple_params(self):
self.mod.write(
"def a_func(param1, param2):\n p = param1 + param2\n"
"var1 = 1\nvar2 = 1\na_func(var1, var2)\n"
)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("var1 = 1\nvar2 = 1\np = var1 + var2\n", self.mod.read())
def test_parameters_renaming_for_passed_constants(self):
self.mod.write("def a_func(param):\n print(param)\na_func(1)\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("print(1)\n", self.mod.read())
def test_parameters_renaming_for_passed_statements(self):
self.mod.write("def a_func(param):\n " "print(param)\na_func((1 + 2) / 3)\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("print((1 + 2) / 3)\n", self.mod.read())
def test_simple_parameters_renam_for_multiple_params_using_keywords(self):
self.mod.write(
"def a_func(param1, param2):\n "
"p = param1 + param2\n"
"var1 = 1\nvar2 = 1\n"
"a_func(param2=var1, param1=var2)\n"
)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("var1 = 1\nvar2 = 1\np = var2 + var1\n", self.mod.read())
def test_simple_params_renam_for_multi_params_using_mixed_keywords(self):
self.mod.write(
"def a_func(param1, param2):\n p = param1 + param2\n"
"var1 = 1\nvar2 = 1\na_func(var2, param2=var1)\n"
)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("var1 = 1\nvar2 = 1\np = var2 + var1\n", self.mod.read())
def test_simple_putting_in_default_arguments(self):
self.mod.write("def a_func(param=None):\n print(param)\n" "a_func()\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("print(None)\n", self.mod.read())
def test_overriding_default_arguments(self):
self.mod.write(
"def a_func(param1=1, param2=2):"
"\n print(param1, param2)\n"
"a_func(param2=3)\n"
)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("print(1, 3)\n", self.mod.read())
def test_arguments_containing_comparisons(self):
self.mod.write(
"def a_func(param1, param2, param3):"
"\n param2.name\n"
"a_func(2 <= 1, item, True)\n"
)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("item.name\n", self.mod.read())
def test_badly_formatted_text(self):
self.mod.write(
"def a_func ( param1 = 1 ,param2 = 2 ) :"
"\n print(param1, param2)\n"
"a_func ( param2 \n = 3 ) \n"
)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("print(1, 3)\n", self.mod.read())
def test_passing_first_arguments_for_methods(self):
a_class = (
"class A(object):\n"
" def __init__(self):\n"
" self.var = 1\n"
" self.a_func(self.var)\n"
" def a_func(self, param):\n"
" print(param)\n"
)
self.mod.write(a_class)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
expected = (
"class A(object):\n"
" def __init__(self):\n"
" self.var = 1\n"
" print(self.var)\n"
)
self.assertEqual(expected, self.mod.read())
def test_passing_first_arguments_for_methods2(self):
a_class = (
"class A(object):\n"
" def __init__(self):\n"
" self.var = 1\n"
" def a_func(self, param):\n"
" print(param, self.var)\n"
"an_a = A()\n"
"an_a.a_func(1)\n"
)
self.mod.write(a_class)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
expected = (
"class A(object):\n"
" def __init__(self):\n"
" self.var = 1\n"
"an_a = A()\n"
"print(1, an_a.var)\n"
)
self.assertEqual(expected, self.mod.read())
def test_passing_first_arguments_for_methods3(self):
a_class = (
"class A(object):\n"
" def __init__(self):\n"
" self.var = 1\n"
" def a_func(self, param):\n"
" print(param, self.var)\n"
"an_a = A()\n"
"A.a_func(an_a, 1)\n"
)
self.mod.write(a_class)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
expected = (
"class A(object):\n"
" def __init__(self):\n"
" self.var = 1\n"
"an_a = A()\n"
"print(1, an_a.var)\n"
)
self.assertEqual(expected, self.mod.read())
def test_inlining_staticmethods(self):
a_class = (
"class A(object):\n"
" @staticmethod\n"
" def a_func(param):\n"
" print(param)\n"
"A.a_func(1)\n"
)
self.mod.write(a_class)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
expected = "class A(object):\n" " pass\n" "print(1)\n"
self.assertEqual(expected, self.mod.read())
def test_static_methods2(self):
a_class = (
"class A(object):\n"
" var = 10\n"
" @staticmethod\n"
" def a_func(param):\n"
" print(param)\n"
"an_a = A()\n"
"an_a.a_func(1)\n"
"A.a_func(2)\n"
)
self.mod.write(a_class)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
expected = (
"class A(object):\n"
" var = 10\n"
"an_a = A()\n"
"print(1)\n"
"print(2)\n"
)
self.assertEqual(expected, self.mod.read())
def test_inlining_classmethods(self):
a_class = (
"class A(object):\n"
" @classmethod\n"
" def a_func(cls, param):\n"
" print(param)\n"
"A.a_func(1)\n"
)
self.mod.write(a_class)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
expected = "class A(object):\n" " pass\n" "print(1)\n"
self.assertEqual(expected, self.mod.read())
def test_inlining_classmethods2(self):
a_class = (
"class A(object):\n"
" @classmethod\n"
" def a_func(cls, param):\n"
" return cls\n"
"print(A.a_func(1))\n"
)
self.mod.write(a_class)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
expected = "class A(object):\n" " pass\n" "print(A)\n"
self.assertEqual(expected, self.mod.read())
def test_simple_return_values_and_inlining_functions(self):
self.mod.write("def a_func():\n return 1\na = a_func()\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("a = 1\n", self.mod.read())
def test_simple_return_values_and_inlining_lonely_functions(self):
self.mod.write("def a_func():\n return 1\na_func()\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("1\n", self.mod.read())
def test_empty_returns_and_inlining_lonely_functions(self):
self.mod.write("def a_func():\n " "if True:\n return\na_func()\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("if True:\n pass\n", self.mod.read())
def test_multiple_returns(self):
self.mod.write(
"def less_than_five(var):\n if var < 5:\n"
" return True\n return False\n"
"a = less_than_five(2)\n"
)
with self.assertRaises(rope.base.exceptions.RefactoringError):
self._inline2(self.mod, self.mod.read().index("less") + 1)
def test_multiple_returns_and_not_using_the_value(self):
self.mod.write(
"def less_than_five(var):\n if var < 5:\n"
" return True\n "
"return False\nless_than_five(2)\n"
)
self._inline2(self.mod, self.mod.read().index("less") + 1)
self.assertEqual("if 2 < 5:\n True\nFalse\n", self.mod.read())
def test_raising_exception_for_list_arguments(self):
self.mod.write("def a_func(*args):\n print(args)\na_func(1)\n")
with self.assertRaises(rope.base.exceptions.RefactoringError):
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
def test_raising_exception_for_list_keywods(self):
self.mod.write("def a_func(**kwds):\n print(kwds)\na_func(n=1)\n")
with self.assertRaises(rope.base.exceptions.RefactoringError):
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
def test_function_parameters_and_returns_in_other_functions(self):
code = (
"def a_func(param1, param2):\n"
" return param1 + param2\n"
"range(a_func(20, param2=abs(10)))\n"
)
self.mod.write(code)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("range(20 + abs(10))\n", self.mod.read())
def test_function_references_other_than_call(self):
self.mod.write("def a_func(param):\n print(param)\nf = a_func\n")
with self.assertRaises(rope.base.exceptions.RefactoringError):
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
def test_function_referencing_itself(self):
self.mod.write("def a_func(var):\n func = a_func\n")
with self.assertRaises(rope.base.exceptions.RefactoringError):
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
def test_recursive_functions(self):
self.mod.write("def a_func(var):\n a_func(var)\n")
with self.assertRaises(rope.base.exceptions.RefactoringError):
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
# TODO: inlining on function parameters
def xxx_test_inlining_function_default_parameters(self):
self.mod.write("def a_func(p1=1):\n pass\na_func()\n")
self._inline2(self.mod, self.mod.read().index("p1") + 1)
self.assertEqual("def a_func(p1=1):\n pass\na_func()\n", self.mod.read())
def test_simple_inlining_after_extra_indented_lines(self):
self.mod.write(
"def a_func():\n for i in range(10):\n pass\n"
"if True:\n pass\na_func()\n"
)
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual(
"if True:\n pass\nfor i in range(10):" "\n pass\n", self.mod.read()
)
def test_inlining_a_function_with_pydoc(self):
self.mod.write('def a_func():\n """docs"""\n a = 1\na_func()')
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("a = 1\n", self.mod.read())
def test_inlining_methods(self):
self.mod.write(
"class A(object):\n name = 'hey'\n"
" def get_name(self):\n return self.name\n"
"a = A()\nname = a.get_name()\n"
)
self._inline2(self.mod, self.mod.read().rindex("get_name") + 1)
self.assertEqual(
"class A(object):\n name = 'hey'\n" "a = A()\nname = a.name\n",
self.mod.read(),
)
def test_simple_returns_with_backslashes(self):
self.mod.write("def a_func():\n return 1" "\\\n + 2\na = a_func()\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("a = 1 + 2\n", self.mod.read())
def test_a_function_with_pass_body(self):
self.mod.write("def a_func():\n print(1)\na = a_func()\n")
self._inline2(self.mod, self.mod.read().index("a_func") + 1)
self.assertEqual("print(1)\na = None\n", self.mod.read())
def test_inlining_the_last_method_of_a_class(self):
self.mod.write("class A(object):\n" " def a_func(self):\n pass\n")
self._inline2(self.mod, self.mod.read().rindex("a_func") + 1)
self.assertEqual("class A(object):\n pass\n", self.mod.read())
def test_adding_needed_imports_in_the_dest_module(self):
self.mod.write("import sys\n\ndef ver():\n print(sys.version)\n")
self.mod2.write("import mod\n\nmod.ver()")
self._inline2(self.mod, self.mod.read().index("ver") + 1)
self.assertEqual(
"import mod\nimport sys\n\nprint(sys.version)\n", self.mod2.read()
)
def test_adding_needed_imports_in_the_dest_module_removing_selfs(self):
self.mod.write("import mod2\n\ndef f():\n print(mod2.var)\n")
self.mod2.write("import mod\n\nvar = 1\nmod.f()\n")
self._inline2(self.mod, self.mod.read().index("f(") + 1)
self.assertEqual("import mod\n\nvar = 1\nprint(var)\n", self.mod2.read())
def test_handling_relative_imports_when_inlining(self):
pkg = testutils.create_package(self.project, "pkg")
mod3 = testutils.create_module(self.project, "mod3", pkg)
mod4 = testutils.create_module(self.project, "mod4", pkg)
mod4.write("var = 1\n")
mod3.write("from . import mod4\n\ndef f():\n print(mod4.var)\n")
self.mod.write("import pkg.mod3\n\npkg.mod3.f()\n")
self._inline2(self.mod, self.mod.read().index("f(") + 1)
# Cannot determine the exact import
self.assertTrue("\n\nprint(mod4.var)\n" in self.mod.read())
def test_adding_needed_imports_for_elements_in_source(self):
self.mod.write("def f1():\n return f2()\ndef f2():\n return 1\n")
self.mod2.write("import mod\n\nprint(mod.f1())\n")
self._inline2(self.mod, self.mod.read().index("f1") + 1)
self.assertEqual(
"import mod\nfrom mod import f2\n\nprint(f2())\n", self.mod2.read()
)
def test_relative_imports_and_changing_inlining_body(self):
pkg = testutils.create_package(self.project, "pkg")
mod3 = testutils.create_module(self.project, "mod3", pkg)
mod4 = testutils.create_module(self.project, "mod4", pkg)
mod4.write("var = 1\n")
mod3.write("import mod4\n\ndef f():\n print(mod4.var)\n")
self.mod.write("import pkg.mod3\n\npkg.mod3.f()\n")
self._inline2(self.mod, self.mod.read().index("f(") + 1)
self.assertEqual(
"import pkg.mod3\nimport pkg.mod4\n\nprint(pkg.mod4.var)\n", self.mod.read()
)
def test_inlining_with_different_returns(self):
self.mod.write(
"def f(p):\n return p\n" "print(f(1))\nprint(f(2))\nprint(f(1))\n"
)
self._inline2(self.mod, self.mod.read().index("f(") + 1)
self.assertEqual("print(1)\nprint(2)\nprint(1)\n", self.mod.read())
def test_not_removing_definition_for_variables(self):
code = "a_var = 10\nanother_var = a_var\n"
refactored = self._inline(code, code.index("a_var") + 1, remove=False)
self.assertEqual("a_var = 10\nanother_var = 10\n", refactored)
def test_not_removing_definition_for_methods(self):
code = "def func():\n print(1)\n\nfunc()\n"
refactored = self._inline(code, code.index("func") + 1, remove=False)
self.assertEqual("def func():\n print(1)\n\nprint(1)\n", refactored)
def test_only_current_for_methods(self):
code = "def func():\n print(1)\n\nfunc()\nfunc()\n"
refactored = self._inline(
code, code.rindex("func") + 1, remove=False, only_current=True
)
self.assertEqual("def func():\n print(1)\n\nfunc()\nprint(1)\n", refactored)
def test_only_current_for_variables(self):
code = "one = 1\n\na = one\nb = one\n"
refactored = self._inline(
code, code.rindex("one") + 1, remove=False, only_current=True
)
self.assertEqual("one = 1\n\na = one\nb = 1\n", refactored)
def test_inlining_one_line_functions(self):
code = "def f(): return 1\nvar = f()\n"
refactored = self._inline(code, code.rindex("f"))
self.assertEqual("var = 1\n", refactored)
def test_inlining_one_line_functions_with_breaks(self):
code = "def f(\np): return p\nvar = f(1)\n"
refactored = self._inline(code, code.rindex("f"))
self.assertEqual("var = 1\n", refactored)
def test_inlining_one_line_functions_with_breaks2(self):
code = "def f(\n): return 1\nvar = f()\n"
refactored = self._inline(code, code.rindex("f"))
self.assertEqual("var = 1\n", refactored)
def test_resources_parameter(self):
self.mod.write("def a_func():\n print(1)\n")
mod1 = testutils.create_module(self.project, "mod1")
mod1.write("import mod\nmod.a_func()\n")
self._inline2(self.mod, self.mod.read().index("a_func"), resources=[self.mod])
self.assertEqual("", self.mod.read())
self.assertEqual("import mod\nmod.a_func()\n", mod1.read())
def test_inlining_parameters(self):
code = "def f(p=1):\n pass\nf()\n"
result = self._inline(code, code.index("p"))
self.assertEqual("def f(p=1):\n pass\nf(1)\n", result)
def test_inlining_function_with_line_breaks_in_args(self):
code = "def f(p): return p\nvar = f(1 +\n1)\n"
refactored = self._inline(code, code.rindex("f"))
self.assertEqual("var = 1 + 1\n", refactored)
def test_inlining_variables_before_comparison(self):
code = "start = 1\nprint(start <= 2)\n"
refactored = self._inline(code, code.index("start"))
self.assertEqual("print(1 <= 2)\n", refactored)
def test_inlining_variables_in_other_modules(self):
self.mod.write("myvar = 1\n")
self.mod2.write("import mod\nprint(mod.myvar)\n")
self._inline2(self.mod, 2)
self.assertEqual("import mod\nprint(1)\n", self.mod2.read())
def test_inlining_variables_and_back_importing(self):
self.mod.write("mainvar = 1\nmyvar = mainvar\n")
self.mod2.write("import mod\nprint(mod.myvar)\n")
self._inline2(self.mod, self.mod.read().index("myvar"))
expected = "import mod\n" "from mod import mainvar\n" "print(mainvar)\n"
self.assertEqual(expected, self.mod2.read())
def test_inlining_variables_and_importing_used_imports(self):
self.mod.write("import sys\nmyvar = sys.argv\n")
self.mod2.write("import mod\nprint(mod.myvar)\n")
self._inline2(self.mod, self.mod.read().index("myvar"))
expected = "import mod\n" "import sys\n" "print(sys.argv)\n"
self.assertEqual(expected, self.mod2.read())
def test_inlining_variables_and_removing_old_froms(self):
self.mod.write("var = 1\n")
self.mod2.write("from mod import var\nprint(var)\n")
self._inline2(self.mod2, self.mod2.read().rindex("var"))
self.assertEqual("print(1)\n", self.mod2.read())
def test_inlining_method_and_removing_old_froms(self):
self.mod.write("def f(): return 1\n")
self.mod2.write("from mod import f\nprint(f())\n")
self._inline2(self.mod2, self.mod2.read().rindex("f"))
self.assertEqual("print(1)\n", self.mod2.read())
def test_inlining_functions_in_other_modules_and_only_current(self):
code1 = "def f():\n" " return 1\n" "print(f())\n"
code2 = "import mod\n" "print(mod.f())\n" "print(mod.f())\n"
self.mod.write(code1)
self.mod2.write(code2)
self._inline2(
self.mod2, self.mod2.read().rindex("f"), remove=False, only_current=True
)
expected2 = "import mod\n" "print(mod.f())\n" "print(1)\n"
self.assertEqual(code1, self.mod.read())
self.assertEqual(expected2, self.mod2.read())
def test_inlining_variables_in_other_modules_and_only_current(self):
code1 = "var = 1\n" "print(var)\n"
code2 = "import mod\n" "print(mod.var)\n" "print(mod.var)\n"
self.mod.write(code1)
self.mod2.write(code2)
self._inline2(
self.mod2, self.mod2.read().rindex("var"), remove=False, only_current=True
)
expected2 = "import mod\n" "print(mod.var)\n" "print(1)\n"
self.assertEqual(code1, self.mod.read())
self.assertEqual(expected2, self.mod2.read())
def test_inlining_does_not_change_string_constants(self):
code = "var = 1\n" 'print("var\\\n' '")\n'
expected = "var = 1\n" 'print("var\\\n' '")\n'
refactored = self._inline(
code, code.rindex("var"), remove=False, only_current=True, docs=False
)
self.assertEqual(expected, refactored)
def test_inlining_does_change_string_constants_if_docs_is_set(self):
code = "var = 1\n" 'print("var\\\n' '")\n'
expected = "var = 1\n" 'print("1\\\n' '")\n'
refactored = self._inline(
code, code.rindex("var"), remove=False, only_current=True, docs=True
)
self.assertEqual(expected, refactored)
@testutils.only_for_versions_higher("3.6")
def test_inlining_into_format_string(self):
code = dedent(
"""\
var = 123
print(f"{var}")
"""
)
expected = dedent(
"""\
print(f"{123}")
"""
)
refactored = self._inline(code, code.rindex("var"))
self.assertEqual(expected, refactored)
@testutils.only_for_versions_higher("3.6")
def test_inlining_into_format_string_containing_quotes(self):
code = dedent(
'''\
var = 123
print(f" '{var}' ")
print(f""" "{var}" """)
print(f' "{var}" ')
'''
)
expected = dedent(
'''\
print(f" '{123}' ")
print(f""" "{123}" """)
print(f' "{123}" ')
'''
)
refactored = self._inline(code, code.rindex("var"))
self.assertEqual(expected, refactored)