-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in marshalling can cause a TypeError #75
Labels
bug
Something isn't working
Comments
robyoung
added a commit
to robyoung/flask-restx
that referenced
this issue
Mar 9, 2020
When marshalling receiving a `MarshallingError` is much more useful than receiving the underlying exception directly as the `MarshallingError` has context about where it happened and it means all marshalling issues can be handled in one place. This change also catches `TypeError`s from the int and float formatters so that they are correctly turned into `MarshallingError`s.
robyoung
added a commit
to robyoung/flask-restx
that referenced
this issue
May 16, 2020
When marshalling receiving a `MarshallingError` is much more useful than receiving the underlying exception directly as the `MarshallingError` has context about where it happened and it means all marshalling issues can be handled in one place. This change also catches `TypeError`s from the int and float formatters so that they are correctly turned into `MarshallingError`s.
robyoung
added a commit
to robyoung/flask-restx
that referenced
this issue
May 16, 2020
When marshalling receiving a `MarshallingError` is much more useful than receiving the underlying exception directly as the `MarshallingError` has context about where it happened and it means all marshalling issues can be handled in one place. This change also catches `TypeError`s from the int and float formatters so that they are correctly turned into `MarshallingError`s.
j5awry
added a commit
that referenced
this issue
May 29, 2020
Fix Issue #75: Catch TypeError in marshalling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code
Expected Behavior
Given the example code I would expect to receive a
MarshallingError
with a useful error message directing me to where the problem is.Actual Behavior
I receive a
TypeError
only telling me the underlying error with no context.Environment
Additional Context
I have a PR incoming for this. I am opening this issue as that is what the CONTRIBUTING guidelines suggest.
The text was updated successfully, but these errors were encountered: