Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not call got_request_exception for exceptions explicitly handled #349

Merged

Conversation

vaustrup
Copy link

@vaustrup vaustrup commented Jul 5, 2021

Cherry-picked the changes by @chandlernine from #294 and added a test in test_errors.py as advised.

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #349 (872cc97) into master (0dc1c3c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #349   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          20       20           
  Lines        2740     2740           
=======================================
  Hits         2654     2654           
  Misses         86       86           
Impacted Files Coverage Δ
flask_restx/api.py 96.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc1c3c...872cc97. Read the comment docs.

@j5awry
Copy link
Contributor

j5awry commented Jul 8, 2021

@VolkaRacho thank you for adding tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants