Issue #240: use default on None Float field #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
=======================================
Coverage 96.77% 96.78%
=======================================
Files 20 20
Lines 2732 2734 +2
=======================================
+ Hits 2644 2646 +2
Misses 88 88
Continue to review full report at Codecov.
|
bdscharf
changed the title
j5awry
approved these changes
Jun 1, 2021
This was referenced Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issue #240 and provides a test to cover the case. Picks up from where PR #277 stalled.
.venv is also added to the .gitignore (created by virtual-fish--let me know if you'd like it removed!