Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade swagger ui to 3.48.0 #316

Merged
merged 1 commit into from May 27, 2021
Merged

Conversation

xuhdev
Copy link
Contributor

@xuhdev xuhdev commented May 18, 2021

Close #300

@xuhdev xuhdev marked this pull request as ready for review May 18, 2021 22:54
@xuhdev
Copy link
Contributor Author

xuhdev commented May 18, 2021

I have verified that this upgrade works and solves #300.

@j5awry
Copy link
Contributor

j5awry commented May 19, 2021

@physikerwelt would you have the ability to test his proposed fix for #300?

@xuhdev
Copy link
Contributor Author

xuhdev commented May 22, 2021

@physikerwelt Would you mind testing it out :)

@xuhdev
Copy link
Contributor Author

xuhdev commented May 24, 2021

Could you help review and consider merging it, please? We are also waiting for the fix on our side and would like to avoid using a fork if possible. Thanks!

@physikerwelt
Copy link
Contributor

Yes, I can certainly test it. I am not exactly sure how, but I will figure it out.

@physikerwelt
Copy link
Contributor

It works nicely with
http://127.0.0.1:5000/?tryItOutEnabled=true
Is there any way to enable this option permanently on the server side?

@physikerwelt
Copy link
Contributor

Yes, I can certainly test it. I am not exactly sure how, but I will figure it out.

Thanks to @ziirish I manged to test it. Thank you.

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #316 (1c70816) into master (a39e06f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          20       20           
  Lines        2730     2730           
=======================================
  Hits         2643     2643           
  Misses         87       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a39e06f...1c70816. Read the comment docs.

@xuhdev
Copy link
Contributor Author

xuhdev commented May 26, 2021

Thanks @physikerwelt ! You should be able to enable it by default by configuring it in swagger-config.yaml or environment variables: https://swagger.io/docs/open-source-tools/swagger-ui/usage/configuration/

@j5awry j5awry merged commit f74c9ad into python-restx:master May 27, 2021
@xuhdev xuhdev deleted the upgrade-swagger-ui branch May 27, 2021 18:01
@xuhdev
Copy link
Contributor Author

xuhdev commented May 27, 2021

Could you make a new release :) Thanks!

@xuhdev
Copy link
Contributor Author

xuhdev commented Jun 3, 2021

Could you make a new release for this PR? Installing from the git repo won't get the new swagger UI version :( Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tryItOutEnabled
3 participants