Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.0 Release #6972

Closed
neersighted opened this issue Nov 4, 2022 · 17 comments · Fixed by #7137
Closed

1.3.0 Release #6972

neersighted opened this issue Nov 4, 2022 · 17 comments · Fixed by #7137
Labels
kind/release Meta-issues/PRs as part of the release process

Comments

@neersighted
Copy link
Member

neersighted commented Nov 4, 2022

This issue tracks the progress of version 1.3.0 of Poetry. Please surface any blockers or concerns you have regarding this minor release here:

Blockers

Nice to have

Important changes to surface

(This is intended to be the basis for the blog post and should cover new features or any manual steps/incompatibility when upgrading)

@neersighted neersighted added the kind/release Meta-issues/PRs as part of the release process label Nov 4, 2022
@finswimmer
Copy link
Member

finswimmer commented Nov 4, 2022

@dimbleby
Copy link
Contributor

dimbleby commented Nov 4, 2022

At time of writing, there are quite a lot of straightforward pull requests queued up. I don't think any of them should block a release - I'm in favour of releasing more often! - but also I don't know any reason they shouldn't be merged and included.

Trying to err on the side of caution, I'd still suggest that the following look ready to go:

edit: I forgot about poetry-core, let's add

(though acknowledging that they're both mine, perhaps I'm biased)

@dimbleby
Copy link
Contributor

dimbleby commented Nov 5, 2022

#6747 is maybe also desirable (needs a poetry-core release first)

@neersighted
Copy link
Member Author

Edited; I'll start taking a look at finishing/merging the low hanging fruit later today.

@rickzinit
Copy link

any possibility to release v.1.3.0 this week?

@neersighted
Copy link
Member Author

As ever, soon/when we can.

@neersighted
Copy link
Member Author

Regarding python-poetry/poetry-core#517, consensus is that we need to weigh it against python-poetry/poetry-core#521 (which looks promising but has poor tests/needs more exploration), and that neither should block release.

@neersighted
Copy link
Member Author

Regarding #6709, without CI to validate it, and with other work needed to migrate Poetry to the (eminent) 1.0 release, I am inclined to defer it to reduce risk and my need to manually validate the change.

python-poetry/cleo#248 would be nice, but we can bump Cleo in a patch release and @Secrus has limited bandwidth to get #6709 reviewed/Poetry rebased on top of the breaking changes in Cleo 1.0.

@neersighted
Copy link
Member Author

neersighted commented Nov 18, 2022

The status of 1.3 looks like this: we need a core release (and core is ready to release), then we need to rebase one PR against Poetry on our "nice-to-have" list to account for that. We can then review & merge that PR, prepare a version bump, and draft our release notes/CHANGELOG.

@dimbleby
Copy link
Contributor

re cleo, I have code sitting around locally that fixes up the remaining type errors if and when the cleo release happens.

So if cleo were to release 1.0 soon, and if y'all did want to get that into 1.3.0 - then it should be possible to move fast.

I don't know that that's especially desirable - I can think of a couple of useful bug-fixes, but nothing that couldn't wait for a 1.3.1 or whatever - and certainly I wouldn't advocate blocking poetry 1.3.0 on cleo.

@neersighted
Copy link
Member Author

That's pretty much where it's at -- there's not benefit to the partial approach before 1.0 is ready, and Cleo 1.0 is mostly blocked on bandwidth. What we have works, let's ship that and then we can use automated tooling to make changes for Cleo 1.0 with more confidence once it is tagged; then backport it if desired to make life easier to the distro packagers.

@dimbleby
Copy link
Contributor

dimbleby commented Nov 18, 2022

Just so we're clear, I'm saying that Secrus bandwidth to rebase poetry on cleo 1.0 breaking changes need not be a factor, I have that done already.

(again, I'm nevertheless fully ok with not waiting for cleo)

@neersighted
Copy link
Member Author

Cleo 2.0.0 (nee 1.0.0) is pulled in for this release; and poetry-core 1.4.0 is tagged and ready for dependent PRs to be rebased on.

@neersighted
Copy link
Member Author

We've surfaced a new blocker: #6950 is necessary to improve our CI coverage, and has revealed failures on Python 3.9 / Windows with a simple version bump. Resolving these failures (either as a false positive or as breakage we need to fix, or at the very least a dependency version we need to exclude using constraints) needs to be done before we can tag 1.3.0.

@finswimmer
Copy link
Member

If we have the time I would like to see #7100 in 1.3 as there are already other fixes regarding virtualenvs.prefer-active-python.

@dimbleby
Copy link
Contributor

dimbleby commented Dec 8, 2022

Ship it!

I'm not sure what it is that causes poetry's release-paralysis - is the release process burdensome? is there anything the rest of us can do to make it not burdensome?

So far as I can see the codebase has been in a sensible state to cut a release for quite some time; let's do it, and move on to the next one.

(There's only so many times I can tell people to clear their cache, releasing the fixes is a much more scalable solution...)

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/release Meta-issues/PRs as part of the release process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants