Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace lockfile with fasteners or oslo.concurrency #6881

Closed
2 tasks done
mrk-andreev opened this issue Oct 25, 2022 · 5 comments
Closed
2 tasks done

Replace lockfile with fasteners or oslo.concurrency #6881

mrk-andreev opened this issue Oct 25, 2022 · 5 comments
Labels
status/external-issue Issue is caused by external project (platform, dep, etc)

Comments

@mrk-andreev
Copy link

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the FAQ and general documentation and believe that my question is not already covered.

Feature Request

Poetry use lockfile==0.12.2 that deprecated. https://pypi.org/project/lockfile/

Note: This package is deprecated. It is highly preferred that instead of using this code base that instead [fasteners](https://pypi.python.org/pypi/fasteners) or [oslo.concurrency](http://docs.openstack.org/developer/oslo.concurrency/) is used instead. For any questions or comments or further help needed please email [openstack-dev](http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev) and prefix your email subject with [oslo][pylockfile] (for a faster response).

I suggest to migrate to non-deprecated libraries.

@mrk-andreev mrk-andreev added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Oct 25, 2022
@Secrus
Copy link
Member

Secrus commented Oct 25, 2022

This is not our direct dependency, but a dependency of the cachecontrol library, which we use. We don't have direct influence over this. cachecontrol has already switched to a different library, but it was not released yet.

@Secrus Secrus closed this as completed Oct 25, 2022
@neersighted neersighted added status/external-issue Issue is caused by external project (platform, dep, etc) and removed kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Oct 25, 2022
@bryteise
Copy link

bryteise commented Mar 8, 2023

This was true in October but now https://github.com/python-poetry/poetry/blob/master/src/poetry/utils/authenticator.py#L15 is using it directly. And it was added to the pyproject with #7169 which seems bad.

@mrk-andreev
Copy link
Author

@Secrus

@Secrus
Copy link
Member

Secrus commented Mar 13, 2023

The issue remains the same. we had to include lockfile as direct dependency, as we had customized our lock class. The lockfile will be removed when we drop cachecontrol or when cachecontrol changes their implementation (or just release new version, since the change was already made).

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/external-issue Issue is caused by external project (platform, dep, etc)
Projects
None yet
Development

No branches or pull requests

4 participants