Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a RuntimeError on hash mismatch in Chooser._get_links #3885

Merged
merged 1 commit into from Apr 29, 2021
Merged

Throw a RuntimeError on hash mismatch in Chooser._get_links #3885

merged 1 commit into from Apr 29, 2021

Conversation

0xDEC0DE
Copy link
Contributor

@0xDEC0DE 0xDEC0DE commented Apr 7, 2021

Throw a specific exception in the case of finding a matching name+version, but none of the digests for a link matching the poetry.lock metadata.

Resolves: #2422

  • [✅] Added tests for changed code.
  • [✅] Updated documentation for changed code.

@0xDEC0DE
Copy link
Contributor Author

0xDEC0DE commented Apr 7, 2021

This will work best with python-poetry/poetry-core#159

@0xDEC0DE 0xDEC0DE changed the title Additional info in Chooser.choose_for() exception message Throw a RuntimeException on hash mismatch in Chooser._get_links Apr 8, 2021
@0xDEC0DE 0xDEC0DE requested a review from sdispater April 9, 2021 21:04
Throw a specific exception in the case of finding a matching
name+version, but none of the digests for a link matching the
`poetry.lock` metadata.

Fixes Issue #2422
@0xDEC0DE 0xDEC0DE changed the title Throw a RuntimeException on hash mismatch in Chooser._get_links Throw a RuntimeError on hash mismatch in Chooser._get_links Apr 14, 2021
Copy link
Member

@sdispater sdispater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poetry.lock hashes not checked when running poetry install
3 participants