Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using cloned VCS (git) repositories for update and lock instead of cloning it to /tmp all the time to save on data traffic #3420

Closed
2 tasks done
dolfandringa opened this issue Nov 26, 2020 · 2 comments
Labels
area/solver Related to the dependency resolver kind/feature Feature requests/implementations

Comments

@dolfandringa
Copy link

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

For large git repositories, cloning them all the time takes a considerable amount of time. I have a dependency in git that is 1.8Gb in size. Every poetry update and similar calls results in a full clone of that repository to /tmp, even with develop=True in the dependency config. Even on a decent internet connection that takes a lot of time. It would be a lot faster if there was an option that would cause poetry to clone that repository to a dedicated folder and just do a git pull on it, instead of a full clone to /tmp.

I am thinking of 2 options:

  1. Whendevelop=True make sure to just clone to {virtualenv.path}/src directory if the package isn't there yet, or do a git pull there if it does exist, and use that directory in the update command.
  2. Add a separate option keep_source to the dependency config that makes poetry update use the checked out code in {virtualenv.path}/src for the update (or check it out if it's not there yet).
@dolfandringa dolfandringa added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Nov 26, 2020
@dimbleby
Copy link
Contributor

fixed, #6131 prevents unnecessary updates when nothing has changed, this can be closed

@neersighted neersighted added area/solver Related to the dependency resolver and removed status/triage This issue needs to be triaged labels Oct 29, 2022
Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/solver Related to the dependency resolver kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

3 participants