Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows default terminal can't handle color codes: --no-ansi by default? #159

Closed
madig opened this issue May 30, 2018 · 10 comments
Closed

Windows default terminal can't handle color codes: --no-ansi by default? #159

madig opened this issue May 30, 2018 · 10 comments
Labels
area/cli Related to the command line kind/bug Something isn't working as expected

Comments

@madig
Copy link

madig commented May 30, 2018

The default Windows terminal (below) and even Hyper (above) can't handle color codes:
image

Maybe make --no-ansi the default on Windows? Or allow me to set the setting system-wide?
@grilo
Copy link

grilo commented May 30, 2018

I confirm this also happens on the default terminal of W10 build 17677.

Poetry is using the "cleo" library to manage the output, this probably should be fixed there instead.

@sdispater
Copy link
Member

Actually, cleo behaves properly but a modification I made in poetry always activates the "decorated" mode by default.

This should be an easy fix. I will keep you posted.

@moigagoo
Copy link
Contributor

Wouldn't it be an option to switch to a crossplatform coloring package like Colorama? As a Windows user, I like fancy colors too :-)

@madig
Copy link
Author

madig commented May 31, 2018

They seem to have Windows issues as well? tartley/colorama#104

@moigagoo
Copy link
Contributor

@madig Hmmm, I've been using it in a few crossplatform projects, no issues so far.

@moigagoo
Copy link
Contributor

FYI colors are shown just fine in ConEmu.

@sdispater sdispater added kind/bug Something isn't working as expected area/cli Related to the command line labels May 31, 2018
@sdispater
Copy link
Member

This should be fixed in the latest release (0.10.2)

@madig
Copy link
Author

madig commented Jun 1, 2018

Works for me in 0.10.2. Thanks!

@madig madig closed this as completed Jun 1, 2018
@vberlier
Copy link

Hmm... I'm using ConEmu as the integrated VS Code terminal and I have kind of the same problem.

image

The colors work fine in ConEmu but don't show up through VS Code. However they work when piping the output to cat.

@antiz antiz mentioned this issue Oct 23, 2018
Closed
1 task
dimbleby pushed a commit to dimbleby/poetry that referenced this issue Apr 21, 2022
@0xDEC0DE @nisimond
Simplify/improve Package.clone() (python-poetry#159)
3f718c5 
Downstream clients (e.g., poetry) appear to assume that the result
of a Package.clone() will be a full-fidelity copy of the original.

Use `copy.deepcopy` to clone the object, and ensure that this is
the case.

Resolves Issue python-poetry#2422

Co-authored-by: Nicolas Simonds <nisimond@cisco.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/cli Related to the command line kind/bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@madig @sdispater @moigagoo @grilo @vberlier