Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small number of carefully curated screenshots to handbook tutorial #7962

Open
aclark4life opened this issue Apr 10, 2024 · 5 comments
Open

Comments

@aclark4life
Copy link
Member

Anyone interested in seeing a few ideally helpful screenshots added to the handbook tutorial? E.g.

Screenshot 2024-04-10 at 8 33 10 AM

I may like to see this done, but am also concerned we shouldn't be adding images to the main repository for a variety of reasons perhaps, but mostly size concerns.

I'm working on a Pillow demo where I follow the handbook tutorial and if nothing else they can go there. But I also wanted to rule-out-or-in the possibility of including some of these screenshots in the handbook proper. Thanks for any thoughts.

@wiredfool
Copy link
Member

I think images/screenshots in the tutorial are a net benefit.

@Yay295
Copy link
Contributor

Yay295 commented Apr 10, 2024

Could images in the documentation be external links, instead of keeping them all in this repository? It might make updating the images a bit more difficult, but I don't think that would need to happen often.

@aclark4life
Copy link
Member Author

Could images in the documentation be external links, instead of keeping them all in this repository? It might make updating the images a bit more difficult, but I don't think that would need to happen often.

Maybe, but may not be worth doing in that case. Also just checked the distribution and we don't include any of the docs anyway so as long as these screenshots are not LFS-size should be OK, stay tuned for PR.

@radarhere
Copy link
Member

@aclark4life is this still something on your to-do list, or should someone else take a crack at it?

@aclark4life
Copy link
Member Author

aclark4life commented May 2, 2024

A lot of them I've done already in some form over here, but haven't added them back yet, PRs welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants