Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that only the RAWBITS variants of PPM files are supported #7297

Closed
samwyse opened this issue Jul 21, 2023 · 4 comments · Fixed by #7298
Closed

Note that only the RAWBITS variants of PPM files are supported #7297

samwyse opened this issue Jul 21, 2023 · 4 comments · Fixed by #7298

Comments

@samwyse
Copy link

samwyse commented Jul 21, 2023

Having this documented would have saved me a couple of hours of web searches.

See https://github.com/samwyse/Pillow/tree/samwyse-patch-1

@hugovk hugovk transferred this issue from python-pillow/python-pillow.github.io Jul 21, 2023
@radarhere
Copy link
Member

When you say that only P4, P5 and P6 are supported, are you saying that you can't open images with that format, or you can't save images with that format?

Because I think you should be able to open images with that format, thanks to #5242 in Pillow 9.2.0. Are you using an earlier version of Pillow?

If you're talking about saving, we can add a note to the documentation if you like.

Also, where does the term "RAWBITS" come from? I can't see it in https://netpbm.sourceforge.net/doc/ppm.html.

@samwyse
Copy link
Author

samwyse commented Jul 22, 2023 via email

@radarhere
Copy link
Member

I notice now that https://netpbm.sourceforge.net/doc/ppm.html does refer to "plain" and "raw" formats

There is actually another version of the PPM format that is fairly rare: "plain" PPM format. The format above, which generally considered the normal one, is known as the "raw" PPM format.

I've created PR #7298. See what you think.

@samwyse
Copy link
Author

samwyse commented Jul 22, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants