Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only use ASCII characters in C source file #6691

Merged
merged 1 commit into from Oct 27, 2022
Merged

Only use ASCII characters in C source file #6691

merged 1 commit into from Oct 27, 2022

Conversation

cgohlke
Copy link
Contributor

@cgohlke cgohlke commented Oct 26, 2022

No description provided.

hugovk
hugovk approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but curious why non-ASCII is a problem?

@hugovk hugovk added this to the 9.3.0 milestone Oct 27, 2022
@hugovk hugovk merged commit 10aa3bd into python-pillow:main Oct 27, 2022
@cgohlke
Copy link
Contributor Author

cgohlke commented Oct 27, 2022

I'm fine with this, but curious why non-ASCII is a problem?

PVS-Studio raised a warning about "Code contains invisible characters that may alter its logic". I'm not sure the warning was legitimate but this PR fixes the warning at least.

@sync-by-unito sync-by-unito bot mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cgohlke @hugovk