Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverted to __array_interface__ with the release of NumPy 1.23 #6394

Merged
merged 1 commit into from Jun 25, 2022

Conversation

radarhere
Copy link
Member

Resolves #5815

#5379 was created to workaround a bug in NumPy. That bug has now been fixed in NumPy 1.23, so this PR reverts the src change from #5379.

@radarhere
Copy link
Member Author

The MinGW 32-bit GitHub Actions job has started failing not just here, but also on main, with 'test_adobe_deflate_tiff'.

Comparing the failing job and the last passing job, the failing job has libtiff-4.4.0-2, while the passing one has libtiff-4.4.0-1.

The package is actually up to 4.4.0-4 at present, and those more recent changes mention libdeflate. So I expect this will solve itself whenever the MinGW image is updated.

@hugovk hugovk merged commit b1e9a3c into python-pillow:main Jun 25, 2022
@hugovk
Copy link
Member

hugovk commented Jun 25, 2022

Shall we skip the bad test for now, so it doesn't interfere with next week's release?

@radarhere radarhere deleted the numpy branch June 25, 2022 06:45
@nulano
Copy link
Contributor

nulano commented Jun 25, 2022

AFAIK the virtual environments seem to have roughly weekly releases, with the latest one being from the 19th (probably right before the libtiff rebuild). So I'd expect the error clear up before the release. Perhaps disable the test if it is still failing on Wed/Thu?

@hugovk
Copy link
Member

hugovk commented Jun 25, 2022

Fine by me, if failing builds aren't too distracting in the meantime :)

@radarhere
Copy link
Member Author

The MinGW 32-bit job has started passing again - https://github.com/python-pillow/Pillow/runs/7102756365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Image.tobytes return type to ByteArray or add a Image.tobytearray method
3 participants