Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Wheels from Christoph Gohlke Going Away Forever #6369

Closed
wiredfool opened this issue Jun 15, 2022 · 10 comments
Closed

Windows Wheels from Christoph Gohlke Going Away Forever #6369

wiredfool opened this issue Jun 15, 2022 · 10 comments
Labels
Milestone

Comments

@wiredfool
Copy link
Member

According to Christoph Gohlke, https://www.lfd.uci.edu/~gohlke/pythonlibs/ his lab has lost funding and the unofficial python wheels collection, and likely our official windows wheels, is going away before the end of next month.

@hugovk
Copy link
Member

hugovk commented Jun 15, 2022

Funding for the Laboratory for Fluorescence Dynamics has ceased. This service will be discontinued before July 2022.

I'm very sorry to hear this. Thank you @cgohlke, for providing an invaluable service to the Python community for 12+ years. And thank you for all your work helping with Pillow too.

Do you think you'll be able to make a last set of Windows wheels for our July 1 release?

@hugovk hugovk added this to the 9.2.0 milestone Jun 15, 2022
@aclark4life
Copy link
Member

aclark4life commented Jun 15, 2022

End of an era, thanks @wiredfool for reporting and thank you @cgohlke for being there for Pillow since the beginning!! Not to mention dozens of other projects … 🙏

@hugovk We probably better figure something out sooner rather than later … can you or @wiredfool or @radarhere remind me how far we got on wheels doing it ourselves last time? Seems like we got close … let's keep rollin! rollin! rollin!

@aclark4life
Copy link
Member

@hugovk @cgohlke Maybe we can push the July release up a week or so if that would help… then we'd have 3 months or so to figure out something else assuming we don't need to do a bug fix release 🤞🤷

@hugovk
Copy link
Member

hugovk commented Jun 15, 2022

We are actually building wheels on GitHub Actions for Windows (for example, see the "dist-main" link at https://github.com/python-pillow/Pillow/actions/runs/2495168122), but as I recall there's one or two things needed for them to be on par with the release ones.

@nulano, do you know what's needed?

@aclark4life We would also like to put out wheels for 3.11 beta, see #6367, and need to check if multibuild is ready to do 3.11 for Linux/macOS.

(If we wanted to overhaul our wheel building, we could look at the newish https://github.com/pypa/cibuildwheel which can do wheels for all of Windows/Linux/macOS, but that's a bit longer term thing. That could also let us automate uploading releases to PyPI.)

@cgohlke
Copy link
Contributor

cgohlke commented Jun 15, 2022

Do you think you'll be able to make a last set of Windows wheels for our July 1 release?

Sure.

@nulano
Copy link
Contributor

nulano commented Jun 16, 2022

We are actually building wheels on GitHub Actions for Windows [...] but as I recall there's one or two things needed for them to be on par with the release ones.

IIRC the only thing missing was to check all dependencies are built with the same optimizations and optional dependencies enabled.

I'm pretty sure FreeType (and other font libs) was fine when I last checked, and zlib/libjpeg-turbo do not have dependencies themselves. The build explicitly disables OpenMP for ImageQuant, but that is not included in wheels anyway. The others build with their default configs (some patched to use /MD and the correct Windows SDK), so presumably should be fine as well.

Edit: I've looked through the dependency tree in #6562 (comment).

@yasamoka

This comment was marked as off-topic.

@aclark4life aclark4life pinned this issue Jun 27, 2022
@aclark4life aclark4life changed the title Windows Wheels Windows Wheels from Christoph Gohlke Going Away Forever Jun 27, 2022
@radarhere radarhere modified the milestones: 9.2.0, 9.3.0 Jul 2, 2022
@radarhere
Copy link
Member

So is this then just a matter of updating the RELEASING checklist, to ensure that we are now using GitHub Actions? I've created PR #6458

@radarhere
Copy link
Member

Pillow 9.3.0 has now been released - the first release with Windows wheels generated from GitHub Actions.

@radarhere
Copy link
Member

Thanks very much to all involved in helping us make this transition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants