Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SourceForge auto mirror capability #6345

Merged

Conversation

raygard
Copy link
Contributor

@raygard raygard commented Jun 1, 2022

Use SourceForge auto mirror capability.

Fixes #6343 .

Changes proposed in this pull request:

  • Use SourceForge auto mirror capability

Use SourceForge auto mirror capability.
@radarhere radarhere changed the title Update build_prepare.py Use SourceForge auto mirror capability Jun 1, 2022
@nulano
Copy link
Contributor

nulano commented Jun 2, 2022

#6343 (comment):

@nulano this looks to be above my comfort level with GitHub etc. I hope someone else can help me with this. I think the PR is fine but would love some help before it goes out to the world.

I've made the changes in a new branch: https://github.com/raygard/Pillow/compare/winbuild_use_sourceforge_auto_mirror...nulano:patch-1

The CI runs are here:
GitHub Actions: https://github.com/nulano/Pillow/actions/runs/2425275727
AppVeyor: https://ci.appveyor.com/project/nulano/pillow/builds/43732459

The runs are successfully downloading the dependencies:

Fetching https://sourceforge.net/projects/libjpeg-turbo/files/2.1.3/libjpeg-turbo-2.1.3.tar.gz/download (attempt 1)...
Extracting libjpeg-turbo-2.1.3.tar.gz

@hugovk
Copy link
Member

hugovk commented Jun 2, 2022

3.11-dev failed yesterday because the new 3.11 beta 2 didn't play nicely with pytest, but they fixed it with an expedited 3.11 beta 3.

I've restarted the failing 3.11-dev jobs and they now pass 👍

Thanks all!

@hugovk hugovk merged commit 05d979d into python-pillow:main Jun 2, 2022
@raygard raygard deleted the winbuild_use_sourceforge_auto_mirror branch July 13, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows build from source cannot find sourceforge dependencies
4 participants